Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Flaky test] Fix basic auth integration test #15561

Merged
merged 10 commits into from
Dec 23, 2023
Merged

Conversation

kfaraz
Copy link
Contributor

@kfaraz kfaraz commented Dec 14, 2023

Database slowness while doing audits seems to be causing flakiness in auth ITs.
The failing test is almost always ITBasicAuthConfigurationTest.test_avaticaQuery_datasourceAndContextParamsUser but in some rare cases, other tests fail too. Alternately, this failing test has been seen to pass too.

It is most likely because the auth changes are not able to propagate in time from the coordinator to other services.

Fix for now

Just log the audits rather than persisting them to database. Most audits have been newly added and it is okay to not have them persisted. Moreover, logging audits can also be more beneficial while debugging an IT.

Later

  • We should consider persisting audits to metadata store in an async fashion.
  • Add some ITs that specifically test metadata-based audits.

@kfaraz kfaraz changed the title [Do Not Merge] Verify basic auth integration test [Do Not Merge] Fix basic auth integration test Dec 20, 2023
@kfaraz kfaraz changed the title [Do Not Merge] Fix basic auth integration test Fix basic auth integration test Dec 23, 2023
@kfaraz kfaraz changed the title Fix basic auth integration test [Flaky test] Fix basic auth integration test Dec 23, 2023
@kfaraz
Copy link
Contributor Author

kfaraz commented Dec 23, 2023

Thanks for the review, @AmatyaAvadhanula , @pranavbhole !

@kfaraz kfaraz merged commit cce5394 into apache:master Dec 23, 2023
83 checks passed
@kfaraz kfaraz deleted the test_auth_it branch December 23, 2023 06:41
@LakshSingla LakshSingla added this to the 29.0.0 milestone Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants