-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Flaky test] Fix basic auth integration test #15561
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kfaraz
changed the title
[Do Not Merge] Verify basic auth integration test
[Do Not Merge] Fix basic auth integration test
Dec 20, 2023
10 tasks
kfaraz
changed the title
[Do Not Merge] Fix basic auth integration test
Fix basic auth integration test
Dec 23, 2023
kfaraz
changed the title
Fix basic auth integration test
[Flaky test] Fix basic auth integration test
Dec 23, 2023
pranavbhole
approved these changes
Dec 23, 2023
AmatyaAvadhanula
approved these changes
Dec 23, 2023
Thanks for the review, @AmatyaAvadhanula , @pranavbhole ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Database slowness while doing audits seems to be causing flakiness in auth ITs.
The failing test is almost always
ITBasicAuthConfigurationTest.test_avaticaQuery_datasourceAndContextParamsUser
but in some rare cases, other tests fail too. Alternately, this failing test has been seen to pass too.It is most likely because the auth changes are not able to propagate in time from the coordinator to other services.
Fix for now
Just log the audits rather than persisting them to database. Most audits have been newly added and it is okay to not have them persisted. Moreover, logging audits can also be more beneficial while debugging an IT.
Later