Skip to content

Commit

Permalink
[Flaky test] Fix basic auth integration test (#15561)
Browse files Browse the repository at this point in the history
Database slowness while doing audits seems to be causing flakiness in auth ITs.

The failing test is almost always
`ITBasicAuthConfigurationTest.test_avaticaQuery_datasourceAndContextParamsUser`
but in some rare cases, other tests fail too. Alternately, this failing test has been seen to pass too.

It is most likely because the auth changes are not able to propagate in time from
the coordinator to other services.

Fix: Just log the audits rather than persisting them to database.
Most audits have been newly added and it is okay to not have them persisted.
Moreover, logging audits can also be more beneficial while debugging an IT.
  • Loading branch information
kfaraz authored Dec 23, 2023
1 parent a2e65e6 commit cce5394
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions integration-tests/docker/environment-configs/common
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,7 @@ druid_coordinator_kill_supervisor_period=PT10S
druid_coordinator_kill_supervisor_durationToRetain=PT0M
druid_coordinator_period_metadataStoreManagementPeriod=PT10S
druid_sql_planner_authorizeSystemTablesDirectly=true
druid_audit_manager_type=log

# Testing the legacy config from https://github.com/apache/druid/pull/10267
# Can remove this when the flag is no longer needed
Expand Down

0 comments on commit cce5394

Please sign in to comment.