Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix](nereids) fix bind expression compare dbname ignore cluster #39114

Merged
merged 2 commits into from
Aug 9, 2024
Merged

[Fix](nereids) fix bind expression compare dbname ignore cluster #39114

merged 2 commits into from
Aug 9, 2024

Conversation

feiniaofeiafei
Copy link
Contributor

@feiniaofeiafei feiniaofeiafei commented Aug 8, 2024 •
edited
Loading

This pr is similar with #23008, ignoring cluster_name in binding when compare dbname. e.g. in this sql, the "dbname" should be viewed same db when comparing with "default_cluster:dbname"

select dbname.test_db_name_ignore_cluster.a from `default_cluster:dbname`.test_db_name_ignore_cluster;

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@feiniaofeiafei
Copy link
Contributor Author

run buildall

@github-actions github-actions bot added the doing label Aug 8, 2024
@doris-robot
Copy link

TPC-H: Total hot run time: 39168 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 1202ba81d3ba5ef98dd354ff0a35877851ae65a0, data reload: false

------ Round 1 ----------------------------------
q1	17638	4752	4285	4285
q2	2025	179	182	179
q3	10469	1234	1065	1065
q4	10144	768	707	707
q5	7506	2490	2504	2490
q6	225	139	141	139
q7	967	594	589	589
q8	9210	1894	2024	1894
q9	8821	6574	6514	6514
q10	7073	2186	2302	2186
q11	471	250	246	246
q12	514	227	231	227
q13	17855	2967	2937	2937
q14	271	229	248	229
q15	528	486	494	486
q16	498	391	378	378
q17	975	583	693	583
q18	7920	7468	7456	7456
q19	4653	994	1109	994
q20	666	316	326	316
q21	5271	4292	4617	4292
q22	1071	1023	976	976
Total cold run time: 114771 ms
Total hot run time: 39168 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4447	4322	4288	4288
q2	382	269	262	262
q3	2833	2610	2646	2610
q4	2025	1661	1733	1661
q5	5512	5629	5451	5451
q6	220	135	138	135
q7	2121	1744	1731	1731
q8	3307	3438	3401	3401
q9	8697	8717	8773	8717
q10	3543	3253	3249	3249
q11	599	503	490	490
q12	795	616	587	587
q13	16286	3149	3183	3149
q14	312	283	282	282
q15	542	493	491	491
q16	508	445	447	445
q17	1826	1556	1483	1483
q18	8109	7855	7773	7773
q19	1740	1558	1620	1558
q20	2159	1930	1872	1872
q21	9404	5351	5389	5351
q22	1109	1008	996	996
Total cold run time: 76476 ms
Total hot run time: 55982 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 202881 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 1202ba81d3ba5ef98dd354ff0a35877851ae65a0, data reload: false

query1	939	414	389	389
query2	6447	1956	1936	1936
query3	6630	206	210	206
query4	34566	23436	23195	23195
query5	3630	482	485	482
query6	289	187	179	179
query7	4577	296	291	291
query8	241	205	204	204
query9	8463	2386	2358	2358
query10	938	854	936	854
query11	15577	15029	14943	14943
query12	134	98	109	98
query13	1634	391	372	372
query14	10259	7889	7849	7849
query15	331	336	310	310
query16	7652	504	460	460
query17	1704	593	540	540
query18	2036	387	380	380
query19	248	222	219	219
query20	118	118	112	112
query21	234	106	102	102
query22	4619	4469	4326	4326
query23	34114	33601	33547	33547
query24	10666	2972	2996	2972
query25	572	369	370	369
query26	693	153	150	150
query27	2165	283	281	281
query28	5656	2002	1990	1990
query29	796	417	404	404
query30	268	152	154	152
query31	955	747	730	730
query32	107	53	56	53
query33	625	306	272	272
query34	868	476	478	476
query35	956	832	803	803
query36	1063	914	899	899
query37	137	81	79	79
query38	4274	4144	4116	4116
query39	1472	1428	1385	1385
query40	193	116	112	112
query41	44	42	44	42
query42	115	96	96	96
query43	497	479	486	479
query44	1102	755	735	735
query45	398	392	383	383
query46	1127	828	759	759
query47	1812	1760	1757	1757
query48	369	313	294	294
query49	831	422	427	422
query50	810	412	423	412
query51	6815	6683	6590	6590
query52	99	86	95	86
query53	253	185	184	184
query54	871	446	446	446
query55	76	75	76	75
query56	267	236	235	235
query57	1110	1059	1058	1058
query58	225	222	225	222
query59	2974	2859	2862	2859
query60	287	255	261	255
query61	93	92	108	92
query62	820	639	645	639
query63	210	179	179	179
query64	9227	2438	1926	1926
query65	3233	3155	3121	3121
query66	751	326	323	323
query67	15319	14823	14763	14763
query68	4469	557	540	540
query69	424	384	372	372
query70	1205	1155	1121	1121
query71	394	277	268	268
query72	17842	16432	16094	16094
query73	760	330	334	330
query74	9120	8749	8676	8676
query75	3372	2690	2664	2664
query76	2137	983	1022	983
query77	455	306	304	304
query78	9743	9054	8903	8903
query79	3062	520	515	515
query80	1969	490	481	481
query81	613	233	226	226
query82	993	139	139	139
query83	316	161	150	150
query84	274	80	79	79
query85	1765	308	301	301
query86	469	280	276	276
query87	4656	4463	4524	4463
query88	4675	2500	2513	2500
query89	401	282	284	282
query90	1790	205	196	196
query91	141	122	123	122
query92	58	110	53	53
query93	3725	536	533	533
query94	894	288	304	288
query95	353	259	261	259
query96	614	276	281	276
query97	3226	3087	3033	3033
query98	224	200	195	195
query99	1549	1249	1232	1232
Total cold run time: 308269 ms
Total hot run time: 202881 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.78 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 1202ba81d3ba5ef98dd354ff0a35877851ae65a0, data reload: false

query1	0.05	0.04	0.04
query2	0.08	0.04	0.04
query3	0.22	0.05	0.05
query4	1.68	0.08	0.08
query5	0.50	0.49	0.50
query6	1.13	0.74	0.73
query7	0.02	0.01	0.01
query8	0.05	0.04	0.05
query9	0.54	0.49	0.48
query10	0.54	0.54	0.53
query11	0.15	0.11	0.11
query12	0.15	0.12	0.11
query13	0.60	0.60	0.58
query14	0.75	0.80	0.77
query15	0.87	0.82	0.81
query16	0.36	0.37	0.36
query17	1.00	0.97	0.95
query18	0.23	0.21	0.22
query19	1.80	1.69	1.70
query20	0.01	0.01	0.03
query21	15.38	0.73	0.65
query22	4.41	7.38	2.19
query23	18.29	1.36	1.21
query24	2.06	0.23	0.23
query25	0.14	0.08	0.09
query26	0.29	0.22	0.21
query27	0.46	0.22	0.23
query28	13.31	1.03	1.01
query29	12.58	3.32	3.30
query30	0.24	0.06	0.05
query31	2.87	0.41	0.39
query32	3.25	0.50	0.48
query33	2.89	2.91	2.96
query34	16.88	4.32	4.35
query35	4.40	4.40	4.40
query36	0.64	0.48	0.46
query37	0.18	0.15	0.16
query38	0.15	0.14	0.14
query39	0.04	0.04	0.04
query40	0.15	0.12	0.12
query41	0.10	0.05	0.05
query42	0.06	0.04	0.04
query43	0.05	0.05	0.04
Total cold run time: 109.55 s
Total hot run time: 30.78 s

@feiniaofeiafei
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 39396 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 83289b678bb16a42c3c0b2eb2fe3882dd824a8b3, data reload: false

------ Round 1 ----------------------------------
q1	17610	4301	4299	4299
q2	2013	173	171	171
q3	10513	1157	1093	1093
q4	10135	723	721	721
q5	7500	2483	2472	2472
q6	218	135	138	135
q7	966	600	585	585
q8	9211	1892	1898	1892
q9	8815	6574	6514	6514
q10	7069	2188	2181	2181
q11	479	238	245	238
q12	515	227	222	222
q13	17779	3000	2958	2958
q14	275	229	228	228
q15	527	483	487	483
q16	498	389	392	389
q17	972	690	714	690
q18	7963	7400	7390	7390
q19	5313	1091	1101	1091
q20	693	349	334	334
q21	5433	4326	4603	4326
q22	1081	988	984	984
Total cold run time: 115578 ms
Total hot run time: 39396 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4514	4275	4309	4275
q2	370	278	263	263
q3	2821	2623	2667	2623
q4	1940	1689	1728	1689
q5	5498	5587	5475	5475
q6	243	135	137	135
q7	2156	1747	1797	1747
q8	3278	3416	3400	3400
q9	8818	8738	8862	8738
q10	3493	3235	3286	3235
q11	594	499	502	499
q12	786	623	615	615
q13	15811	3206	3206	3206
q14	314	315	305	305
q15	522	490	481	481
q16	500	459	442	442
q17	1833	1534	1505	1505
q18	8166	7911	7720	7720
q19	1701	1527	1572	1527
q20	2155	1893	1900	1893
q21	9626	5330	5545	5330
q22	1090	990	1017	990
Total cold run time: 76229 ms
Total hot run time: 56093 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 203230 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 83289b678bb16a42c3c0b2eb2fe3882dd824a8b3, data reload: false

query1	961	430	403	403
query2	6448	1915	1836	1836
query3	6633	206	219	206
query4	34086	23273	23078	23078
query5	3671	507	501	501
query6	272	194	196	194
query7	4588	297	301	297
query8	237	213	208	208
query9	8468	2403	2363	2363
query10	919	903	925	903
query11	16134	15047	14983	14983
query12	144	101	101	101
query13	1644	393	391	391
query14	10612	8335	6363	6363
query15	383	357	348	348
query16	7387	471	501	471
query17	1734	589	578	578
query18	1962	427	410	410
query19	273	232	224	224
query20	132	118	119	118
query21	213	106	105	105
query22	4617	4501	4636	4501
query23	34539	33623	33678	33623
query24	7781	3078	3004	3004
query25	623	396	399	396
query26	700	160	156	156
query27	2132	296	289	289
query28	5801	2012	2009	2009
query29	785	437	434	434
query30	258	160	151	151
query31	998	806	744	744
query32	88	54	57	54
query33	585	285	288	285
query34	858	475	489	475
query35	935	857	806	806
query36	1035	958	883	883
query37	144	80	82	80
query38	4315	4188	4116	4116
query39	1424	1383	1388	1383
query40	204	118	118	118
query41	48	44	43	43
query42	118	97	97	97
query43	508	476	446	446
query44	1093	749	737	737
query45	409	385	374	374
query46	1135	807	807	807
query47	1857	1751	1776	1751
query48	408	306	300	300
query49	852	437	434	434
query50	821	413	409	409
query51	6822	6753	6666	6666
query52	107	92	91	91
query53	265	182	183	182
query54	899	456	457	456
query55	81	73	73	73
query56	270	254	253	253
query57	1119	1097	1060	1060
query58	228	239	246	239
query59	2937	2568	2715	2568
query60	297	279	264	264
query61	101	93	90	90
query62	765	635	638	635
query63	216	187	184	184
query64	9229	2438	1926	1926
query65	3219	3168	3156	3156
query66	761	343	326	326
query67	15371	14919	14970	14919
query68	6183	543	554	543
query69	454	411	427	411
query70	1249	1162	1112	1112
query71	520	270	275	270
query72	20415	17125	17917	17125
query73	858	341	327	327
query74	9270	8790	8787	8787
query75	4283	2685	2696	2685
query76	4198	981	973	973
query77	752	305	337	305
query78	10629	8957	8907	8907
query79	7048	532	531	531
query80	1053	515	504	504
query81	598	238	229	229
query82	744	140	146	140
query83	296	157	165	157
query84	282	80	84	80
query85	1279	316	301	301
query86	399	277	284	277
query87	4854	4516	4606	4516
query88	5064	2545	2486	2486
query89	435	288	289	288
query90	1982	199	198	198
query91	157	127	121	121
query92	69	48	51	48
query93	5533	545	544	544
query94	931	275	309	275
query95	355	260	271	260
query96	633	288	281	281
query97	3203	3028	3028	3028
query98	208	197	207	197
query99	1704	1250	1265	1250
Total cold run time: 320297 ms
Total hot run time: 203230 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 31.31 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 83289b678bb16a42c3c0b2eb2fe3882dd824a8b3, data reload: false

query1	0.05	0.04	0.04
query2	0.08	0.04	0.04
query3	0.23	0.05	0.06
query4	1.65	0.09	0.10
query5	0.50	0.50	0.50
query6	1.13	0.72	0.72
query7	0.02	0.01	0.02
query8	0.05	0.04	0.04
query9	0.55	0.48	0.51
query10	0.54	0.54	0.54
query11	0.15	0.11	0.12
query12	0.16	0.12	0.12
query13	0.60	0.61	0.59
query14	0.77	0.78	0.79
query15	0.86	0.83	0.82
query16	0.37	0.36	0.37
query17	1.04	1.05	0.99
query18	0.23	0.21	0.22
query19	1.92	1.74	1.72
query20	0.01	0.01	0.02
query21	15.39	0.74	0.65
query22	4.22	6.47	2.66
query23	18.29	1.42	1.30
query24	2.10	0.23	0.22
query25	0.16	0.09	0.08
query26	0.29	0.20	0.20
query27	0.46	0.22	0.23
query28	13.66	1.03	0.98
query29	12.62	3.27	3.25
query30	0.24	0.07	0.05
query31	2.89	0.40	0.39
query32	3.25	0.48	0.47
query33	2.96	2.87	2.93
query34	17.19	4.43	4.35
query35	4.46	4.36	4.39
query36	0.65	0.48	0.46
query37	0.18	0.15	0.15
query38	0.16	0.15	0.15
query39	0.05	0.04	0.03
query40	0.15	0.13	0.12
query41	0.09	0.05	0.04
query42	0.05	0.05	0.05
query43	0.05	0.05	0.04
Total cold run time: 110.47 s
Total hot run time: 31.31 s

@morrySnow morrySnow added not-merge/2.0 do not merge into 2.0 branch dev/2.1.x usercase Important user case type label and removed doing labels Aug 8, 2024
@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Aug 8, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 8, 2024

PR approved by at least one committer and no changes requested.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 8, 2024

PR approved by anyone and no changes requested.

@924060929 924060929 merged commit a604c4f into apache:master Aug 9, 2024
28 of 30 checks passed
feiniaofeiafei added a commit to feiniaofeiafei/doris that referenced this pull request Aug 9, 2024
@feiniaofeiafei
[Fix](nereids) fix bind expression compare dbname ignore cluster (apa…
fba7fa0 
…che#39114)

This pr is similar with apache#23008, ignoring cluster_name in binding when
compare dbname. e.g. in this sql, the "dbname" should be viewed same db
when comparing with "default_cluster:dbname"
```sql
select dbname.test_db_name_ignore_cluster.a from `default_cluster:dbname`.test_db_name_ignore_cluster; 
```
@feiniaofeiafei feiniaofeiafei mentioned this pull request Aug 9, 2024
Merged
yiguolei pushed a commit that referenced this pull request Aug 10, 2024
@feiniaofeiafei
[Fix](nereids) fix bind expression compare dbname ignore cluster (#39114
3dc150a 
) (#39142)

cherry-pick #39114 to branch-2.1
dataroaring pushed a commit that referenced this pull request Aug 11, 2024
@feiniaofeiafei @dataroaring
[Fix](nereids) fix bind expression compare dbname ignore cluster (#39114
ac45c9b 
)

This pr is similar with #23008, ignoring cluster_name in binding when
compare dbname. e.g. in this sql, the "dbname" should be viewed same db
when comparing with "default_cluster:dbname"
```sql
select dbname.test_db_name_ignore_cluster.a from `default_cluster:dbname`.test_db_name_ignore_cluster; 
```
wyxxxcat pushed a commit to wyxxxcat/doris that referenced this pull request Aug 14, 2024
@feiniaofeiafei @wyxxxcat
[Fix](nereids) fix bind expression compare dbname ignore cluster (apa…
dc73ce7 
…che#39114)

This pr is similar with apache#23008, ignoring cluster_name in binding when
compare dbname. e.g. in this sql, the "dbname" should be viewed same db
when comparing with "default_cluster:dbname"
```sql
select dbname.test_db_name_ignore_cluster.a from `default_cluster:dbname`.test_db_name_ignore_cluster; 
```
dataroaring pushed a commit that referenced this pull request Aug 16, 2024
@feiniaofeiafei @dataroaring
[Fix](nereids) fix bind expression compare dbname ignore cluster (#39114
86ccbff 
)

This pr is similar with #23008, ignoring cluster_name in binding when
compare dbname. e.g. in this sql, the "dbname" should be viewed same db
when comparing with "default_cluster:dbname"
```sql
select dbname.test_db_name_ignore_cluster.a from `default_cluster:dbname`.test_db_name_ignore_cluster; 
```
@yiguolei yiguolei mentioned this pull request Sep 5, 2024
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@morrySnow morrySnow morrySnow approved these changes

@924060929 924060929 924060929 approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. dev/2.1.6-merged dev/3.0.2-merged not-merge/2.0 do not merge into 2.0 branch reviewed usercase Important user case type label
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@feiniaofeiafei @doris-robot @924060929 @morrySnow @yiguolei @dataroaring