Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix](nereids)bind slot failed because of "default_cluster" #23008

Merged
merged 1 commit into from
Aug 16, 2023
Merged

[fix](nereids)bind slot failed because of "default_cluster" #23008

merged 1 commit into from
Aug 16, 2023

Conversation

englefly
Copy link
Contributor

@englefly englefly commented Aug 15, 2023 •
edited
Loading

Proposed changes

slot bind failed for following querys:
select tpch.lineitem.* from lineitem
select tpch.lineitem.l_partkey from lineitem

the unbound slot is tpch.lineitem.l_partkey, but the bounded slot is default_cluster:tpch.lineitem.l_partkey. They are not matched.
we need to ignore default_cluster: when compare dbName

Issue Number: close #xxx

Further comments

If this is a relatively large or complex change, kick off the discussion at [email protected] by explaining why you chose the solution you did and what alternatives you considered, etc...

@englefly
Copy link
Contributor Author

run buildall

@hello-stephen
Copy link
Contributor

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 46.95 seconds
stream load tsv: 510 seconds loaded 74807831229 Bytes, about 139 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s
insert into select: 29.2 seconds inserted 10000000 Rows, about 342K ops/s
storage size: 17162181158 Bytes

@englefly
Copy link
Contributor Author

run buildall

@hello-stephen
Copy link
Contributor

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 46.14 seconds
stream load tsv: 509 seconds loaded 74807831229 Bytes, about 140 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 29.2 seconds inserted 10000000 Rows, about 342K ops/s
storage size: 17162677169 Bytes

@englefly
Copy link
Contributor Author

run buildall

@hello-stephen
Copy link
Contributor

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 45.51 seconds
stream load tsv: 512 seconds loaded 74807831229 Bytes, about 139 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 30 seconds loaded 861443392 Bytes, about 27 MB/s
insert into select: 29.2 seconds inserted 10000000 Rows, about 342K ops/s
storage size: 17162113308 Bytes

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Aug 16, 2023
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@englefly englefly merged commit f1880d3 into apache:master Aug 16, 2023
@englefly englefly deleted the slot-bind branch August 16, 2023 09:22
xiaokang pushed a commit that referenced this pull request Aug 17, 2023
@englefly @xiaokang
[fix](nereids)bind slot failed because of "default_cluster" #23008
de57445 
slot bind failed for following querys:
select tpch.lineitem.* from lineitem
select tpch.lineitem.l_partkey from lineitem

the unbound slot is tpch.lineitem.l_partkey, but the bounded slot is default_cluster:tpch.lineitem.l_partkey. They are not matched.
we need to ignore default_cluster: when compare dbName
airborne12 pushed a commit to airborne12/apache-doris that referenced this pull request Aug 21, 2023
@englefly @airborne12
[fix](nereids)bind slot failed because of "default_cluster" apache#23008
1b517f3 


slot bind failed for following querys:
select tpch.lineitem.* from lineitem
select tpch.lineitem.l_partkey from lineitem

the unbound slot is tpch.lineitem.l_partkey, but the bounded slot is default_cluster:tpch.lineitem.l_partkey. They are not matched.
we need to ignore default_cluster: when compare dbName
@xiaokang xiaokang mentioned this pull request Aug 30, 2023
Open
@feiniaofeiafei feiniaofeiafei mentioned this pull request Aug 8, 2024
Merged
924060929 pushed a commit that referenced this pull request Aug 9, 2024
@feiniaofeiafei
[Fix](nereids) fix bind expression compare dbname ignore cluster (#39114
a604c4f 
)

This pr is similar with #23008, ignoring cluster_name in binding when
compare dbname. e.g. in this sql, the "dbname" should be viewed same db
when comparing with "default_cluster:dbname"
```sql
select dbname.test_db_name_ignore_cluster.a from `default_cluster:dbname`.test_db_name_ignore_cluster; 
```
feiniaofeiafei added a commit to feiniaofeiafei/doris that referenced this pull request Aug 9, 2024
@feiniaofeiafei
[Fix](nereids) fix bind expression compare dbname ignore cluster (apa…
fba7fa0 
…che#39114)

This pr is similar with apache#23008, ignoring cluster_name in binding when
compare dbname. e.g. in this sql, the "dbname" should be viewed same db
when comparing with "default_cluster:dbname"
```sql
select dbname.test_db_name_ignore_cluster.a from `default_cluster:dbname`.test_db_name_ignore_cluster; 
```
dataroaring pushed a commit that referenced this pull request Aug 11, 2024
@feiniaofeiafei @dataroaring
[Fix](nereids) fix bind expression compare dbname ignore cluster (#39114
ac45c9b 
)

This pr is similar with #23008, ignoring cluster_name in binding when
compare dbname. e.g. in this sql, the "dbname" should be viewed same db
when comparing with "default_cluster:dbname"
```sql
select dbname.test_db_name_ignore_cluster.a from `default_cluster:dbname`.test_db_name_ignore_cluster; 
```
wyxxxcat pushed a commit to wyxxxcat/doris that referenced this pull request Aug 14, 2024
@feiniaofeiafei @wyxxxcat
[Fix](nereids) fix bind expression compare dbname ignore cluster (apa…
dc73ce7 
…che#39114)

This pr is similar with apache#23008, ignoring cluster_name in binding when
compare dbname. e.g. in this sql, the "dbname" should be viewed same db
when comparing with "default_cluster:dbname"
```sql
select dbname.test_db_name_ignore_cluster.a from `default_cluster:dbname`.test_db_name_ignore_cluster; 
```
dataroaring pushed a commit that referenced this pull request Aug 16, 2024
@feiniaofeiafei @dataroaring
[Fix](nereids) fix bind expression compare dbname ignore cluster (#39114
86ccbff 
)

This pr is similar with #23008, ignoring cluster_name in binding when
compare dbname. e.g. in this sql, the "dbname" should be viewed same db
when comparing with "default_cluster:dbname"
```sql
select dbname.test_db_name_ignore_cluster.a from `default_cluster:dbname`.test_db_name_ignore_cluster; 
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@morrySnow morrySnow morrySnow approved these changes

@starocean999 starocean999 starocean999 approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. dev/2.0.1-merged p1_query_exception reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@englefly @hello-stephen @starocean999 @morrySnow @xiaokang @morningman