Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix](catalog)fix db name may be null in NotificationEvent #38421

Merged
merged 2 commits into from
Jul 31, 2024
Merged

[fix](catalog)fix db name may be null in NotificationEvent #38421

merged 2 commits into from
Jul 31, 2024

Conversation

zddr
Copy link
Contributor

@zddr zddr commented Jul 26, 2024

cause by: #29059

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@zddr
Copy link
Contributor Author

zddr commented Jul 26, 2024

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 40788 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 81343d37afd7bc9bd675454f05aa786c4d2f4031, data reload: false

------ Round 1 ----------------------------------
q1	17624	4615	4464	4464
q2	1263	207	220	207
q3	10396	1310	1266	1266
q4	10150	787	700	700
q5	7578	2849	2794	2794
q6	244	143	141	141
q7	1045	638	633	633
q8	9221	1983	2022	1983
q9	6799	6730	6730	6730
q10	8866	3891	3903	3891
q11	411	251	260	251
q12	428	241	238	238
q13	17759	3010	2987	2987
q14	288	253	248	248
q15	541	505	502	502
q16	525	401	392	392
q17	1004	675	674	674
q18	8261	7707	7444	7444
q19	1396	1114	1095	1095
q20	616	351	345	345
q21	5542	3501	4097	3501
q22	364	302	313	302
Total cold run time: 110321 ms
Total hot run time: 40788 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4494	4369	4428	4369
q2	396	280	264	264
q3	3111	2830	2838	2830
q4	1994	1632	1626	1626
q5	5380	5401	5408	5401
q6	242	135	135	135
q7	2222	1755	1679	1679
q8	3382	3580	3562	3562
q9	8532	8425	8502	8425
q10	4024	3752	3765	3752
q11	599	494	487	487
q12	809	682	602	602
q13	16892	3009	3019	3009
q14	298	292	269	269
q15	545	503	496	496
q16	483	424	421	421
q17	1918	1544	1509	1509
q18	7836	7644	7439	7439
q19	4976	1637	1644	1637
q20	2056	1837	1789	1789
q21	5035	4871	4763	4763
q22	599	509	507	507
Total cold run time: 75823 ms
Total hot run time: 54971 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 172440 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 81343d37afd7bc9bd675454f05aa786c4d2f4031, data reload: false

query1	905	374	364	364
query2	6455	1918	1863	1863
query3	6668	208	227	208
query4	28502	17572	17485	17485
query5	4187	472	476	472
query6	272	168	179	168
query7	4593	292	285	285
query8	242	202	205	202
query9	8552	2469	2433	2433
query10	443	268	267	267
query11	10658	10095	10049	10049
query12	137	86	86	86
query13	1632	374	367	367
query14	10202	7343	7651	7343
query15	227	174	172	172
query16	7391	478	490	478
query17	1294	583	562	562
query18	1871	292	284	284
query19	194	148	143	143
query20	94	87	86	86
query21	200	104	101	101
query22	4229	4046	4009	4009
query23	33865	33512	33074	33074
query24	12279	2968	2920	2920
query25	694	392	402	392
query26	1696	150	150	150
query27	2931	271	274	271
query28	7437	2002	1994	1994
query29	1071	437	429	429
query30	288	159	151	151
query31	962	730	761	730
query32	94	54	57	54
query33	788	355	339	339
query34	878	469	486	469
query35	858	748	744	744
query36	1092	880	917	880
query37	245	80	80	80
query38	2942	2760	2755	2755
query39	877	818	821	818
query40	266	117	115	115
query41	48	48	48	48
query42	119	99	99	99
query43	509	469	456	456
query44	1199	719	716	716
query45	211	181	179	179
query46	1091	722	755	722
query47	1861	1763	1797	1763
query48	362	295	297	295
query49	1198	420	434	420
query50	831	407	401	401
query51	6849	6730	6668	6668
query52	96	95	88	88
query53	254	184	179	179
query54	940	455	455	455
query55	78	74	76	74
query56	308	288	294	288
query57	1182	1035	1048	1035
query58	393	252	274	252
query59	2807	2646	2616	2616
query60	314	280	295	280
query61	96	97	104	97
query62	841	654	641	641
query63	204	182	174	174
query64	10579	2283	1703	1703
query65	3165	3111	3101	3101
query66	1376	335	343	335
query67	15543	14899	14792	14792
query68	7234	537	553	537
query69	693	483	360	360
query70	1195	1129	1085	1085
query71	547	265	266	265
query72	8609	5441	5765	5441
query73	822	332	329	329
query74	6109	5727	5651	5651
query75	5276	2663	2651	2651
query76	4985	900	937	900
query77	768	333	308	308
query78	9694	9151	9020	9020
query79	7169	520	516	516
query80	2655	474	495	474
query81	579	217	218	217
query82	781	136	131	131
query83	304	170	169	169
query84	275	78	82	78
query85	1582	319	335	319
query86	464	291	320	291
query87	3288	3115	3148	3115
query88	5395	2499	2492	2492
query89	436	289	281	281
query90	2129	197	190	190
query91	127	102	98	98
query92	60	50	48	48
query93	5723	522	521	521
query94	1112	278	294	278
query95	359	261	268	261
query96	618	273	272	272
query97	3152	3072	3045	3045
query98	224	196	201	196
query99	1544	1255	1232	1232
Total cold run time: 304573 ms
Total hot run time: 172440 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.43 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 81343d37afd7bc9bd675454f05aa786c4d2f4031, data reload: false

query1	0.04	0.03	0.03
query2	0.08	0.04	0.04
query3	0.22	0.06	0.06
query4	1.65	0.09	0.09
query5	0.51	0.48	0.49
query6	1.13	0.73	0.73
query7	0.02	0.01	0.02
query8	0.05	0.05	0.04
query9	0.55	0.49	0.49
query10	0.55	0.55	0.54
query11	0.15	0.12	0.12
query12	0.15	0.12	0.12
query13	0.60	0.58	0.59
query14	0.78	0.77	0.78
query15	0.84	0.82	0.81
query16	0.36	0.37	0.36
query17	0.95	0.95	0.96
query18	0.22	0.21	0.22
query19	1.71	1.69	1.68
query20	0.02	0.01	0.01
query21	15.41	0.76	0.65
query22	4.68	7.06	1.73
query23	18.25	1.36	1.32
query24	2.08	0.22	0.24
query25	0.16	0.09	0.09
query26	0.29	0.22	0.21
query27	0.46	0.24	0.23
query28	13.30	1.00	1.01
query29	12.66	3.27	3.27
query30	0.25	0.07	0.05
query31	2.87	0.39	0.40
query32	3.27	0.48	0.47
query33	2.86	2.92	2.94
query34	16.95	4.35	4.37
query35	4.37	4.37	4.42
query36	0.65	0.46	0.48
query37	0.20	0.16	0.16
query38	0.15	0.15	0.15
query39	0.05	0.04	0.03
query40	0.15	0.12	0.13
query41	0.10	0.05	0.04
query42	0.06	0.04	0.05
query43	0.05	0.04	0.04
Total cold run time: 109.85 s
Total hot run time: 30.43 s

@zddr
Copy link
Contributor Author

zddr commented Jul 30, 2024

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 41433 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit edd6bd6dee5adfaec2a0ac1007d570c75e37b8aa, data reload: false

------ Round 1 ----------------------------------
q1	17711	4054	4027	4027
q2	2015	204	200	200
q3	10456	1242	1328	1242
q4	10193	796	914	796
q5	7628	2980	2936	2936
q6	218	138	135	135
q7	1040	613	606	606
q8	9449	1875	1922	1875
q9	8479	6586	6556	6556
q10	8739	3847	3810	3810
q11	430	256	240	240
q12	439	231	229	229
q13	17766	2954	2955	2954
q14	278	245	254	245
q15	528	488	493	488
q16	530	395	382	382
q17	960	911	895	895
q18	7919	7328	7342	7328
q19	1472	1213	1206	1206
q20	564	336	334	334
q21	5295	4671	4761	4671
q22	351	282	278	278
Total cold run time: 112460 ms
Total hot run time: 41433 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4088	4029	4040	4029
q2	326	229	222	222
q3	3008	3007	3085	3007
q4	1961	2006	2008	2006
q5	5523	5495	5456	5456
q6	219	139	131	131
q7	2093	1777	1824	1777
q8	3321	3377	3338	3338
q9	8630	8702	8715	8702
q10	3948	4047	3989	3989
q11	548	440	446	440
q12	748	583	593	583
q13	15249	3112	3065	3065
q14	295	278	270	270
q15	552	490	501	490
q16	466	418	406	406
q17	1779	1690	1695	1690
q18	8156	7737	7628	7628
q19	1798	1747	1707	1707
q20	2049	1859	1880	1859
q21	5673	5475	5373	5373
q22	525	450	485	450
Total cold run time: 70955 ms
Total hot run time: 56618 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 169541 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit edd6bd6dee5adfaec2a0ac1007d570c75e37b8aa, data reload: false

query1	912	375	362	362
query2	6463	1728	1653	1653
query3	6668	213	223	213
query4	19995	17427	17163	17163
query5	3703	497	526	497
query6	279	168	166	166
query7	4588	303	300	300
query8	247	200	198	198
query9	8488	2366	2360	2360
query10	424	270	258	258
query11	10613	9964	9970	9964
query12	117	86	87	86
query13	1617	371	367	367
query14	9549	6989	7017	6989
query15	197	166	162	162
query16	6813	430	447	430
query17	934	549	552	549
query18	1917	281	274	274
query19	200	148	139	139
query20	90	88	85	85
query21	203	100	95	95
query22	4045	3908	3850	3850
query23	33692	33831	33805	33805
query24	10201	3155	3205	3155
query25	684	390	416	390
query26	1734	159	149	149
query27	3120	279	275	275
query28	7629	2001	2006	2001
query29	1324	438	447	438
query30	244	153	156	153
query31	965	791	782	782
query32	107	62	62	62
query33	717	323	327	323
query34	914	478	514	478
query35	905	787	773	773
query36	1053	895	896	895
query37	293	80	81	80
query38	2991	2853	2793	2793
query39	878	814	832	814
query40	291	114	112	112
query41	48	44	43	43
query42	129	97	106	97
query43	464	435	423	423
query44	1175	735	752	735
query45	214	178	173	173
query46	1082	808	753	753
query47	1800	1678	1722	1678
query48	385	296	283	283
query49	1005	420	414	414
query50	906	431	433	431
query51	6774	6573	6673	6573
query52	98	95	89	89
query53	266	181	177	177
query54	617	460	466	460
query55	76	78	76	76
query56	279	264	261	261
query57	1135	1029	1047	1029
query58	286	276	290	276
query59	2567	2498	2351	2351
query60	305	289	287	287
query61	120	116	119	116
query62	883	654	667	654
query63	213	179	185	179
query64	5869	2040	1902	1902
query65	3154	3102	3103	3102
query66	1336	331	328	328
query67	15290	14916	14917	14916
query68	4365	549	563	549
query69	485	293	299	293
query70	1101	1037	1065	1037
query71	448	276	278	276
query72	7934	2729	2502	2502
query73	763	319	336	319
query74	6112	5587	5677	5587
query75	3608	2756	2733	2733
query76	2454	1298	1397	1298
query77	683	310	305	305
query78	9535	8928	8941	8928
query79	1962	547	535	535
query80	2018	518	496	496
query81	554	226	219	219
query82	1043	133	129	129
query83	293	174	176	174
query84	274	80	81	80
query85	1309	362	302	302
query86	441	306	288	288
query87	3292	3136	3097	3097
query88	2896	2409	2381	2381
query89	377	294	287	287
query90	1761	195	197	195
query91	128	102	102	102
query92	60	49	55	49
query93	2067	598	607	598
query94	897	289	287	287
query95	381	263	270	263
query96	605	276	277	276
query97	3223	3042	3028	3028
query98	220	200	202	200
query99	1662	1284	1286	1284
Total cold run time: 265231 ms
Total hot run time: 169541 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 29.94 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit edd6bd6dee5adfaec2a0ac1007d570c75e37b8aa, data reload: false

query1	0.05	0.04	0.03
query2	0.07	0.03	0.04
query3	0.23	0.04	0.04
query4	1.68	0.07	0.08
query5	0.49	0.48	0.49
query6	1.14	0.72	0.71
query7	0.02	0.01	0.02
query8	0.05	0.04	0.05
query9	0.57	0.50	0.52
query10	0.57	0.58	0.57
query11	0.16	0.12	0.11
query12	0.14	0.12	0.12
query13	0.61	0.59	0.60
query14	0.78	0.79	0.80
query15	0.89	0.85	0.86
query16	0.34	0.35	0.35
query17	1.02	1.02	1.02
query18	0.22	0.22	0.21
query19	1.84	1.77	1.79
query20	0.02	0.01	0.01
query21	15.41	0.76	0.66
query22	3.96	8.36	1.23
query23	18.02	1.31	1.31
query24	2.24	0.23	0.22
query25	0.18	0.08	0.08
query26	0.32	0.22	0.22
query27	0.47	0.23	0.24
query28	13.16	0.99	0.97
query29	12.51	3.31	3.27
query30	0.25	0.06	0.06
query31	2.89	0.41	0.40
query32	3.23	0.49	0.48
query33	2.93	2.95	2.93
query34	15.42	4.23	4.26
query35	4.30	4.28	4.29
query36	0.67	0.48	0.49
query37	0.19	0.16	0.17
query38	0.17	0.16	0.15
query39	0.04	0.05	0.04
query40	0.16	0.13	0.12
query41	0.10	0.05	0.04
query42	0.06	0.04	0.05
query43	0.04	0.04	0.04
Total cold run time: 107.61 s
Total hot run time: 29.94 s

@morrySnow morrySnow added dev/2.1.x dev/2.0.x usercase Important user case type label labels Jul 30, 2024
@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jul 30, 2024
@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions GitHub Actions
Copy link
Contributor

PR approved by anyone and no changes requested.

morningman
morningman approved these changes Jul 31, 2024
View reviewed changes
Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morrySnow morrySnow merged commit 3ca9315 into apache:master Jul 31, 2024
28 of 30 checks passed
zddr added a commit to zddr/incubator-doris that referenced this pull request Jul 31, 2024
@zddr
[fix](catalog)fix db name may be null in NotificationEvent (apache#38421
95a69a1 
)

cause by: apache#29059
@zddr zddr mentioned this pull request Jul 31, 2024
Merged
zddr added a commit to zddr/incubator-doris that referenced this pull request Jul 31, 2024
@zddr
[fix](catalog)fix db name may be null in NotificationEvent (apache#38421
844f018 
)

cause by: apache#29059
@zddr zddr mentioned this pull request Jul 31, 2024
Merged
yiguolei pushed a commit that referenced this pull request Jul 31, 2024
@zddr
[fix](catalog)fix db name may be null in NotificationEvent (#38421) (#…
098ac67 
…38596)

pick: #38421
xiaokang pushed a commit that referenced this pull request Aug 1, 2024
@zddr
[fix](catalog)fix db name may be null in NotificationEvent (#38421) (#…
d36ef4e 
…38598)
@xiaokang xiaokang removed the dev/2.0.x label Aug 1, 2024
dataroaring pushed a commit that referenced this pull request Aug 6, 2024
@zddr @dataroaring
[fix](catalog)fix db name may be null in NotificationEvent (#38421)
eb17f8a 
cause by: #29059
feiniaofeiafei pushed a commit to feiniaofeiafei/doris that referenced this pull request Aug 9, 2024
@zddr @feiniaofeiafei
[fix](catalog)fix db name may be null in NotificationEvent (apache#38421
16caf73 
)

cause by: apache#29059
@gavinchou gavinchou mentioned this pull request Aug 19, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@morrySnow morrySnow morrySnow approved these changes

@morningman morningman morningman approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. dev/2.0.14-merged dev/2.1.6-merged dev/3.0.1-merged reviewed usercase Important user case type label
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@zddr @doris-robot @morningman @morrySnow @xiaokang @yiguolei @dataroaring