Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix](hive catalog)When using the hive catalog the hive table name is uppercase, the Doris query is reported wrong #29058 #29059

Merged
merged 1 commit into from
Dec 31, 2023
Merged

[fix](hive catalog)When using the hive catalog the hive table name is uppercase, the Doris query is reported wrong #29058 #29059

merged 1 commit into from
Dec 31, 2023

Conversation

LuGuangming
Copy link
Contributor

…he Doris query is reported wrong #29058

Proposed changes

Issue Number: close #29058

Further comments

If this is a relatively large or complex change, kick off the discussion at [email protected] by explaining why you chose the solution you did and what alternatives you considered, etc...

@LuGuangming LuGuangming changed the title [Bug] When using the hive catalog the hive table name is uppercase, t… [fix](hive catalog)When using the hive catalog the hive table name is uppercase, t… Dec 27, 2023
@LuGuangming
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'

Tpch sf100 test result on commit 240964be5de0d100e3bb1a964ad723f36aa4901b, data reload: false

run tpch-sf100 query with default conf and session variables
q1	5434	5165	5147	5147
q2	394	162	163	162
q3	1459	1152	1155	1152
q4	1089	809	807	807
q5	3179	3109	2998	2998
q6	232	149	140	140
q7	971	554	554	554
q8	2155	2278	2223	2223
q9	6715	6700	6667	6667
q10	3192	3179	3153	3153
q11	342	228	228	228
q12	400	242	246	242
q13	4412	3693	3648	3648
q14	257	228	229	228
q15	622	570	550	550
q16	461	401	408	401
q17	1057	635	542	542
q18	7109	6731	6838	6731
q19	1655	1557	1499	1499
q20	563	361	366	361
q21	2925	2478	2511	2478
q22	386	315	320	315
Total cold run time: 45009 ms
Total hot run time: 40226 ms

run tpch-sf100 query with default conf and set session variable runtime_filter_mode=off
q1	5134	5161	5076	5076
q2	343	261	279	261
q3	3384	3354	3323	3323
q4	2157	2027	2000	2000
q5	5959	5907	5973	5907
q6	239	136	135	135
q7	2435	1912	1935	1912
q8	3603	3672	3689	3672
q9	9110	9027	9071	9027
q10	3892	3916	4076	3916
q11	610	495	485	485
q12	805	657	675	657
q13	3896	3172	3229	3172
q14	308	273	274	273
q15	616	578	571	571
q16	568	530	508	508
q17	2038	1796	1805	1796
q18	8835	8399	8447	8399
q19	1784	1729	1697	1697
q20	2291	2012	1984	1984
q21	5768	5311	5351	5311
q22	609	538	505	505
Total cold run time: 64384 ms
Total hot run time: 60587 ms

@doris-robot
Copy link

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 47.2 seconds
stream load tsv: 578 seconds loaded 74807831229 Bytes, about 123 MB/s
stream load json: 19 seconds loaded 2358488459 Bytes, about 118 MB/s
stream load orc: 66 seconds loaded 1101869774 Bytes, about 15 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 28.3 seconds inserted 10000000 Rows, about 353K ops/s
storage size: 17184040535 Bytes

@yiguolei yiguolei added usercase Important user case type label dev/2.0.4 labels Dec 30, 2023
morningman
morningman approved these changes Dec 31, 2023
View reviewed changes
Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Dec 31, 2023
@github-actions GitHub Actions
Copy link
Contributor

PR approved by anyone and no changes requested.

yiguolei
yiguolei approved these changes Dec 31, 2023
View reviewed changes
Copy link
Contributor

@yiguolei yiguolei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yiguolei yiguolei merged commit f92c0ac into apache:master Dec 31, 2023
27 of 32 checks passed
HappenLee pushed a commit to HappenLee/incubator-doris that referenced this pull request Jan 12, 2024
@LuGuangming @HappenLee
[Bug] When using the hive catalog the hive table name is uppercase, t…
5012b59 
…he Doris query is reported wrong apache#29058 (apache#29059)
@morningman morningman changed the title [fix](hive catalog)When using the hive catalog the hive table name is uppercase, t… [fix](hive catalog)When using the hive catalog the hive table name is uppercase, the Doris query is reported wrong #29058 Feb 4, 2024
@morningman morningman mentioned this pull request Feb 4, 2024
Merged
@zddr zddr mentioned this pull request Jul 26, 2024
Merged
morrySnow pushed a commit that referenced this pull request Jul 31, 2024
@zddr
[fix](catalog)fix db name may be null in NotificationEvent (#38421)
3ca9315 
cause by: #29059
zddr added a commit to zddr/incubator-doris that referenced this pull request Jul 31, 2024
@zddr
[fix](catalog)fix db name may be null in NotificationEvent (apache#38421
95a69a1 
)

cause by: apache#29059
zddr added a commit to zddr/incubator-doris that referenced this pull request Jul 31, 2024
@zddr
[fix](catalog)fix db name may be null in NotificationEvent (apache#38421
844f018 
)

cause by: apache#29059
dataroaring pushed a commit that referenced this pull request Aug 6, 2024
@zddr @dataroaring
[fix](catalog)fix db name may be null in NotificationEvent (#38421)
eb17f8a 
cause by: #29059
feiniaofeiafei pushed a commit to feiniaofeiafei/doris that referenced this pull request Aug 9, 2024
@zddr @feiniaofeiafei
[fix](catalog)fix db name may be null in NotificationEvent (apache#38421
16caf73 
)

cause by: apache#29059
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yiguolei yiguolei yiguolei approved these changes

@morningman morningman morningman approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. dev/2.0.5-merged reviewed usercase Important user case type label
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] When using the hive catalog the hive table name is uppercase, the Doris query is reported wrong
5 participants
@LuGuangming @doris-robot @morningman @yiguolei @xiaokang