-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix](fe) fix several blocking bugs #37756
Conversation
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
run buildall |
TPC-H: Total hot run time: 39765 ms
|
TPC-DS: Total hot run time: 171724 ms
|
ClickBench: Total hot run time: 30.55 s
|
PR approved by anyone and no changes requested. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR approved by at least one committer and no changes requested. |
1. Redundant hashCode of FunctionCallExpr.java This line is redundant, and will cause the amount of hashcode calculation to grow exponentially. 2. A potential deadlock of external catalog The following case may causing this deadlock: - high frequency load. - querying external table join inner table on non-master FE. - refresh external catalog frequently. 3. A workaround to avoid FE restart failure because db does not found introduced from apache#33610 and fixed in apache#36530. This PR is to make previous metadata restart successfully.
1. Redundant hashCode of FunctionCallExpr.java This line is redundant, and will cause the amount of hashcode calculation to grow exponentially. 2. A potential deadlock of external catalog The following case may causing this deadlock: - high frequency load. - querying external table join inner table on non-master FE. - refresh external catalog frequently. 3. A workaround to avoid FE restart failure because db does not found introduced from #33610 and fixed in #36530. This PR is to make previous metadata restart successfully.
Redundant hashCode of FunctionCallExpr.java
This line is redundant, and will cause the amount of hashcode calculation to grow exponentially.
A potential deadlock of external catalog
The following case may causing this deadlock:
A workaround to avoid FE restart failure because db does not found
introduced from [opt](catalog) support using loading cache for db/table list in external catalog #33610 and fixed in [fix](catalog) fix wrong check when using "use_meta_cache=true" #36530.
This PR is to make previous metadata restart successfully.