[fix](catalog) fix wrong check when using "use_meta_cache=true" #36530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
morningman
changed the title
|
run buildall |
morningman
added a commit
that referenced
this pull request
Jun 19, 2024
TPC-H: Total hot run time: 39812 ms |
TPC-DS: Total hot run time: 172020 ms |
ClickBench: Total hot run time: 30.24 s |
wuwenchi
approved these changes
Jun 19, 2024
github-actions
bot
added
the
approved
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
dataroaring
pushed a commit
that referenced
this pull request
Jun 21, 2024
This is PR #33610 introduce a new feature of `use_meta_cache=true`. And made a wrong check when checking this config. And if user enable the hive metastore even listener for hive catalog, it may causing FE unable to restart due to meta data replay error: ``` 2024-06-19 14:25:32,536 ERROR (stateListener|118) [EditLog.loadJournal():1231] Operation Type 325 java.util.NoSuchElementException: No value present at java.util.Optional.get(Optional.java:135) ~[?:1.8.0_341] at org.apache.doris.datasource.ExternalCatalog.replayInitCatalog(ExternalCatalog.java:594) ~[doris-fe.jar:1.2-SNAPSHOT] at org.apache.doris.datasource.CatalogMgr.replayInitCatalog(CatalogMgr.java:584) ~[doris-fe.jar:1.2-SNAPSHOT] at org.apache.doris.persist.EditLog.loadJournal(EditLog.java:1012) ~[doris-fe.jar:1.2-SNAPSHOT] at org.apache.doris.catalog.Env.replayJournal(Env.java:2779) ~[doris-fe.jar:1.2-SNAPSHOT] at org.apache.doris.catalog.Env.transferToMaster(Env.java:1473) ~[doris-fe.jar:1.2-SNAPSHOT] at org.apache.doris.catalog.Env.access$1400(Env.java:324) ~[doris-fe.jar:1.2-SNAPSHOT] at org.apache.doris.catalog.Env$5.runOneCycle(Env.java:2670) ~[doris-fe.jar:1.2-SNAPSHOT] at org.apache.doris.common.util.Daemon.run(Daemon.java:116) ~[doris-fe.jar:1.2-SNAPSHOT] ``` TODO: add hive event listener test suit in external p0
morningman
added a commit
that referenced
this pull request
Jul 15, 2024
1. Redundant hashCode of FunctionCallExpr.java
This line is redundant, and will cause the amount of hashcode
calculation to grow exponentially.
2. A potential deadlock of external catalog
The following case may causing this deadlock:
- high frequency load.
- querying external table join inner table on non-master FE.
- refresh external catalog frequently.
3. A workaround to avoid FE restart failure because db does not found
introduced from #33610 and fixed in #36530.
This PR is to make previous metadata restart successfully.
seawinde
pushed a commit
to seawinde/doris
that referenced
this pull request
Jul 17, 2024
1. Redundant hashCode of FunctionCallExpr.java
This line is redundant, and will cause the amount of hashcode
calculation to grow exponentially.
2. A potential deadlock of external catalog
The following case may causing this deadlock:
- high frequency load.
- querying external table join inner table on non-master FE.
- refresh external catalog frequently.
3. A workaround to avoid FE restart failure because db does not found
introduced from apache#33610 and fixed in apache#36530.
This PR is to make previous metadata restart successfully.
dataroaring
pushed a commit
that referenced
this pull request
Jul 17, 2024
1. Redundant hashCode of FunctionCallExpr.java
This line is redundant, and will cause the amount of hashcode
calculation to grow exponentially.
2. A potential deadlock of external catalog
The following case may causing this deadlock:
- high frequency load.
- querying external table join inner table on non-master FE.
- refresh external catalog frequently.
3. A workaround to avoid FE restart failure because db does not found
introduced from #33610 and fixed in #36530.
This PR is to make previous metadata restart successfully.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is PR #33610 introduce a new feature of
use_meta_cache=true.And made a wrong check when checking this config.
And if user enable the hive metastore even listener for hive catalog,
it may causing FE unable to restart due to meta data replay error:
TODO:
add hive event listener test suit in external p0