Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improvement-15489][api]the vo object suffix,converted to uppercase #15504

Merged
merged 3 commits into from
Jan 18, 2024

Conversation

silenceland
Copy link
Contributor

@silenceland silenceland commented Jan 17, 2024

  • the naming suffix of the objects under the package dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/vo is not unified, such as AlertPluginInstanceVO and ScheduleVo, etc.
  • this pr solve it, and uniformly modified to the VO suffix

Purpose of the pull request

resolve: #15489

Brief change log

These objects under package dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/vo are uniformly modified to the VO suffix
ds-issue15489

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

- the naming suffix of the objects under the package dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/vo is not unified, such as AlertPluginInstanceVO and ScheduleVO, etc.
- this issue solve it, and uniformly modified to the VO suffix
Copy link
Member

@fuchanghai fuchanghai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if CI pass

@fuchanghai fuchanghai added improvement make more easy to user or prompt friendly 3.2.1 labels Jan 18, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jan 18, 2024

Codecov Report

Attention: 16 lines in your changes are missing coverage. Please review.

Comparison is base (64e1e67) 38.02% compared to head (2edc395) 38.02%.

❗ Current head 2edc395 differs from pull request most recent head da8f962. Consider uploading reports for the commit da8f962 to get more accurate results

Files Patch % Lines
...uler/api/service/impl/DataAnalysisServiceImpl.java 44.44% 5 Missing ⚠️
...heduler/api/service/impl/SchedulerServiceImpl.java 0.00% 5 Missing ⚠️
...ache/dolphinscheduler/api/vo/TaskDefinitionVO.java 0.00% 3 Missing ⚠️
...er/api/service/impl/TaskDefinitionServiceImpl.java 0.00% 1 Missing ⚠️
...org/apache/dolphinscheduler/api/vo/ScheduleVO.java 0.00% 1 Missing ⚠️
...hinscheduler/api/vo/WorkflowDefinitionCountVO.java 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##                dev   #15504   +/-   ##
=========================================
  Coverage     38.02%   38.02%           
  Complexity     4692     4692           
=========================================
  Files          1304     1304           
  Lines         44811    44811           
  Branches       4803     4803           
=========================================
  Hits          17038    17038           
  Misses        25922    25922           
  Partials       1851     1851           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fuchanghai fuchanghai changed the title [Improvement-15489][api]rename the vo object suffix [Improvement-15489][api]the vo object suffix,converted to uppercase Jan 18, 2024
Copy link

sonarcloud bot commented Jan 18, 2024

Quality Gate Failed Quality Gate failed

Failed conditions

40.4% Coverage on New Code (required ≥ 60%)

See analysis details on SonarCloud

@fuchanghai fuchanghai merged commit 16c97ef into apache:dev Jan 18, 2024
55 of 56 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.2.1 backend improvement make more easy to user or prompt friendly ready-to-merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Improvement]–[Api]Rename the vo object suffix to VO
3 participants