-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Improvement-15489][api]the vo object suffix,converted to uppercase #15504
Conversation
- the naming suffix of the objects under the package dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/vo is not unified, such as AlertPluginInstanceVO and ScheduleVO, etc. - this issue solve it, and uniformly modified to the VO suffix
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM if CI pass
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## dev #15504 +/- ##
=========================================
Coverage 38.02% 38.02%
Complexity 4692 4692
=========================================
Files 1304 1304
Lines 44811 44811
Branches 4803 4803
=========================================
Hits 17038 17038
Misses 25922 25922
Partials 1851 1851 ☔ View full report in Codecov by Sentry. |
Quality Gate failedFailed conditions 40.4% Coverage on New Code (required ≥ 60%) |
Purpose of the pull request
resolve: #15489
Brief change log
These objects under package dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/vo are uniformly modified to the VO suffix
Verify this pull request
This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(or)
If your pull request contain incompatible change, you should also add it to
docs/docs/en/guide/upgrede/incompatible.md