Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improvement]–[Api]Rename the vo object suffix to VO #15489

Closed
3 tasks done
silenceland opened this issue Jan 16, 2024 · 2 comments · Fixed by #15504
Closed
3 tasks done

[Improvement]–[Api]Rename the vo object suffix to VO #15489

silenceland opened this issue Jan 16, 2024 · 2 comments · Fixed by #15504
Assignees
@silenceland
Labels
improvement make more easy to user or prompt friendly

Comments

@silenceland
Copy link
Contributor

Search before asking

  • I had searched in the issues and found no similar feature requirement.

Description

hi, I found that some vo object naming suffixes under the api module end with Vo, such as ScheduleVo, TaskDefinitionVo, and so on, which is not in line with the specification. I want to submit this issue to unify the naming methods of these objects, end with VO.

Are you willing to submit a PR?

  • Yes I am willing to submit a PR!

Code of Conduct
@silenceland silenceland added improvement make more easy to user or prompt friendly Waiting for reply Waiting for reply labels Jan 16, 2024
@fuchanghai fuchanghai removed the Waiting for reply Waiting for reply label Jan 16, 2024
@ruanwenjun
Copy link
Member

ruanwenjun commented Jan 17, 2024 •
edited
Loading

+1.
Look forward to your PR.

@silenceland silenceland mentioned this issue Jan 17, 2024
Merged
@silenceland
Copy link
Contributor Author

+1. Look forward to your PR.

thx, the pr #15504 submitted

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@silenceland silenceland

Labels
improvement make more easy to user or prompt friendly
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Improvement-15489][api]the vo object suffix,converted to uppercase silenceland/dolphinscheduler
3 participants
@ruanwenjun @fuchanghai @silenceland