-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Improvement-15260][dolphinscheduler-datasource-hana] add hana related dependencies #15260
Conversation
same with #15127 |
cc @caishunfeng |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## dev #15260 +/- ##
============================================
+ Coverage 38.19% 38.23% +0.04%
- Complexity 4673 4695 +22
============================================
Files 1278 1285 +7
Lines 44482 44538 +56
Branches 4783 4783
============================================
+ Hits 16988 17030 +42
- Misses 25632 25646 +14
Partials 1862 1862 ☔ View full report in Codecov by Sentry. |
Kudos, SonarCloud Quality Gate passed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
LGTM
fix typo bug in JSONUtils.java add DBType dolphindb spotless apply & modify ui fix mvn package OK TO DO: Modify DolphinDBDataSourceProcessor fix datasource bug -> connect OK [Improvement-15260][dolphinscheduler-datasource-hana] add hana related dependencies (apache#15260) * add hana related dependencies * optimizing HANA data source bugs * run mvn spotless:apply * Fix hana datasource getValidationQuery() * Fix hana datasource testGetJdbcUrl() --------- Co-authored-by: xujiaqiang <“[email protected]”> Co-authored-by: David Zollo <[email protected]> [Feature-15248][dolphinscheduler-alert-plugins] add alert plugin aliyun-voice (apache#15248) * add alert aliyun-voice * VoiceParam replace these with lombok @DaTa * security.ts add alarm_instance params * optimize alert aliyun vocie code * Merge Code * rollback pnpm-lock.yaml to branch :origin/dev version * add the doc about the new plugin * add com.aliyun.dyvmsapi20170525 version 2.14 * completed * run mvn spotless:apply * Code optimization * Change to @DaTa * Code specification optimization * add com.aliyund.yvmsapi20170525.jar license * modify com.aliyund.yvmsapi20170525.jar license * modify com.aliyund.yvmsapi20170525.jar license * add aliyun-vocie licenses * add aliyun-voice link to docsdev.js * modify vocie module to aliyunVoice * add lisense --------- Co-authored-by: xujiaqiang <“[email protected]”> Co-authored-by: 旺阳 <[email protected]> Co-authored-by: David Zollo <[email protected]> [Feature-15146][dolphinscheduler-task-sqoop] add sqoop source/target type (apache#15146) * task list: sgoop node params optimize * security.ts add alarm_instance params * 1 add SqoopTask params 2 add alert plugin aliyun-voice * add license header * commit sqhoop optimize * pnpm-locl.yaml supplement annotation * remove irrelevent commit. * Code specification optimization * optimize sqoop task ui * Merge Code * add the license header to pnpm-locl.yaml * format the code * format the code * Fix sqoop task echo error --------- Co-authored-by: xujiaqiang <[email protected]> Co-authored-by: xujiaqiang <“[email protected]”> Co-authored-by: David Zollo <[email protected]> finishgit add dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/constants/DataSourceConstants.java Fix k8sTaskExecutionContext setting configYaml (apache#15116) * fixed the issue of obtaining kubeConfig of k8s tasks * removed excess files * removed excess files * formatted the code --------- Co-authored-by: xiangzihao <[email protected]> Co-authored-by: Aaron Wang <[email protected]>
fix typo bug in JSONUtils.java add DBType dolphindb spotless apply & modify ui fix mvn package OK TO DO: Modify DolphinDBDataSourceProcessor fix datasource bug -> connect OK [Improvement-15260][dolphinscheduler-datasource-hana] add hana related dependencies (apache#15260) * add hana related dependencies * optimizing HANA data source bugs * run mvn spotless:apply * Fix hana datasource getValidationQuery() * Fix hana datasource testGetJdbcUrl() --------- Co-authored-by: xujiaqiang <“[email protected]”> Co-authored-by: David Zollo <[email protected]> [Feature-15248][dolphinscheduler-alert-plugins] add alert plugin aliyun-voice (apache#15248) * add alert aliyun-voice * VoiceParam replace these with lombok @DaTa * security.ts add alarm_instance params * optimize alert aliyun vocie code * Merge Code * rollback pnpm-lock.yaml to branch :origin/dev version * add the doc about the new plugin * add com.aliyun.dyvmsapi20170525 version 2.14 * completed * run mvn spotless:apply * Code optimization * Change to @DaTa * Code specification optimization * add com.aliyund.yvmsapi20170525.jar license * modify com.aliyund.yvmsapi20170525.jar license * modify com.aliyund.yvmsapi20170525.jar license * add aliyun-vocie licenses * add aliyun-voice link to docsdev.js * modify vocie module to aliyunVoice * add lisense --------- Co-authored-by: xujiaqiang <“[email protected]”> Co-authored-by: 旺阳 <[email protected]> Co-authored-by: David Zollo <[email protected]> [Feature-15146][dolphinscheduler-task-sqoop] add sqoop source/target type (apache#15146) * task list: sgoop node params optimize * security.ts add alarm_instance params * 1 add SqoopTask params 2 add alert plugin aliyun-voice * add license header * commit sqhoop optimize * pnpm-locl.yaml supplement annotation * remove irrelevent commit. * Code specification optimization * optimize sqoop task ui * Merge Code * add the license header to pnpm-locl.yaml * format the code * format the code * Fix sqoop task echo error --------- Co-authored-by: xujiaqiang <[email protected]> Co-authored-by: xujiaqiang <“[email protected]”> Co-authored-by: David Zollo <[email protected]> finishgit add dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/constants/DataSourceConstants.java Fix k8sTaskExecutionContext setting configYaml (apache#15116) * fixed the issue of obtaining kubeConfig of k8s tasks * removed excess files * removed excess files * formatted the code --------- Co-authored-by: xiangzihao <[email protected]> Co-authored-by: Aaron Wang <[email protected]>
Purpose of the pull request
Brief change log
Verify this pull request
This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(or)
If your pull request contain incompatible change, you should also add it to
docs/docs/en/guide/upgrede/incompatible.md