Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improvement-15260][dolphinscheduler-datasource-hana] add hana related dependencies #15260

Merged
merged 11 commits into from
Dec 12, 2023

Conversation

xujiaqiang
Copy link
Contributor

Purpose of the pull request

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

[Feature][dolphinscheduler-datasource-hana] add hana related dependencies #15259

@xujiaqiang xujiaqiang changed the title [Feature-15146][dolphinscheduler-task-sqoop] add hana related dependencies [Feature-15260][dolphinscheduler-task-sqoop] add hana related dependencies Dec 2, 2023
@xujiaqiang xujiaqiang changed the title [Feature-15260][dolphinscheduler-task-sqoop] add hana related dependencies [Feature-15260][dolphinscheduler-datasource-hana] add hana related dependencies Dec 4, 2023
@fuchanghai
Copy link
Member

same with #15127

@xujiaqiang
Copy link
Contributor Author

xujiaqiang commented Dec 4, 2023

与#15127相同

This feature was developed by me, but not the PR I submitted. I may be clearer on how to modify it. If you need to merge #15127 , please merge it into the dev branch as soon as possible. My #15146 requires this modification item

@fuchanghai
Copy link
Member

与#15127相同

This feature was developed by me, but not the PR I submitted. I may be clearer on how to modify it. If you need to merge #15127 , please merge it into the dev branch as soon as possible. My #15146 requires this modification item

cc @caishunfeng

@davidzollo davidzollo added the first time contributor First-time contributor label Dec 5, 2023
@davidzollo
Copy link
Contributor

image test use in the wrong place

@xujiaqiang xujiaqiang changed the title [Feature-15260][dolphinscheduler-datasource-hana] add hana related dependencies [Bug-15260][dolphinscheduler-datasource-hana] add hana related dependencies Dec 6, 2023
@davidzollo davidzollo changed the title [Bug-15260][dolphinscheduler-datasource-hana] add hana related dependencies [Improvement-15260][dolphinscheduler-datasource-hana] add hana related dependencies Dec 11, 2023
@davidzollo davidzollo added improvement make more easy to user or prompt friendly ready-to-merge labels Dec 11, 2023
@codecov-commenter
Copy link

codecov-commenter commented Dec 12, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (0c470ff) 38.19% compared to head (ad073a9) 38.23%.

❗ Current head ad073a9 differs from pull request most recent head 98670be. Consider uploading reports for the commit 98670be to get more accurate results

Files Patch % Lines
.../plugin/datasource/hana/HanaDataSourceChannel.java 0.00% 2 Missing ⚠️
...in/datasource/hana/HanaPooledDataSourceClient.java 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                dev   #15260      +/-   ##
============================================
+ Coverage     38.19%   38.23%   +0.04%     
- Complexity     4673     4695      +22     
============================================
  Files          1278     1285       +7     
  Lines         44482    44538      +56     
  Branches       4783     4783              
============================================
+ Hits          16988    17030      +42     
- Misses        25632    25646      +14     
  Partials       1862     1862              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Dec 12, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

74.1% 74.1% Coverage
0.0% 0.0% Duplication

Copy link
Contributor

@davidzollo davidzollo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1
LGTM

@davidzollo davidzollo merged commit 0feb144 into apache:dev Dec 12, 2023
53 of 54 checks passed
Wei-Alwayers pushed a commit to Wei-Alwayers/dolphinscheduler that referenced this pull request Dec 15, 2023
fix typo bug in JSONUtils.java

add DBType dolphindb

spotless apply & modify ui

fix mvn package OK

TO DO: Modify DolphinDBDataSourceProcessor

fix datasource bug -> connect OK

[Improvement-15260][dolphinscheduler-datasource-hana] add hana  related dependencies (apache#15260)

* add hana related dependencies

* optimizing HANA data source bugs

* run mvn spotless:apply

* Fix hana datasource getValidationQuery()

* Fix hana datasource testGetJdbcUrl()

---------

Co-authored-by: xujiaqiang <“[email protected]”>
Co-authored-by: David Zollo <[email protected]>

[Feature-15248][dolphinscheduler-alert-plugins] add alert plugin aliyun-voice (apache#15248)

* add alert aliyun-voice

* VoiceParam replace these with lombok @DaTa

* security.ts add alarm_instance params

* optimize alert aliyun vocie code

* Merge Code

* rollback pnpm-lock.yaml to branch :origin/dev version

* add the doc about the new plugin

* add com.aliyun.dyvmsapi20170525 version 2.14

* completed

* run mvn spotless:apply

* Code optimization

* Change to @DaTa

* Code specification optimization

* add com.aliyund.yvmsapi20170525.jar license

* modify com.aliyund.yvmsapi20170525.jar license

* modify com.aliyund.yvmsapi20170525.jar license

* add aliyun-vocie licenses

* add aliyun-voice link to docsdev.js

* modify vocie module to aliyunVoice

* add lisense

---------

Co-authored-by: xujiaqiang <“[email protected]”>
Co-authored-by: 旺阳 <[email protected]>
Co-authored-by: David Zollo <[email protected]>

[Feature-15146][dolphinscheduler-task-sqoop] add sqoop source/target type (apache#15146)

* task list: sgoop node params  optimize

* security.ts  add  alarm_instance params

* 1 add SqoopTask params
2 add alert plugin aliyun-voice

* add license header

* commit sqhoop optimize

* pnpm-locl.yaml supplement annotation

* remove irrelevent commit.

* Code specification optimization

* optimize sqoop task ui

* Merge Code

* add the license header to  pnpm-locl.yaml

* format the code

* format the code

* Fix sqoop task echo error

---------

Co-authored-by: xujiaqiang <[email protected]>
Co-authored-by: xujiaqiang <“[email protected]”>
Co-authored-by: David Zollo <[email protected]>

finishgit add dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/constants/DataSourceConstants.java

Fix k8sTaskExecutionContext setting configYaml (apache#15116)

* fixed the issue of obtaining kubeConfig of k8s tasks

* removed excess files

* removed excess files

* formatted the code

---------

Co-authored-by: xiangzihao <[email protected]>
Co-authored-by: Aaron Wang <[email protected]>
Wei-Alwayers pushed a commit to Wei-Alwayers/dolphinscheduler that referenced this pull request Dec 15, 2023
fix typo bug in JSONUtils.java

add DBType dolphindb

spotless apply & modify ui

fix mvn package OK

TO DO: Modify DolphinDBDataSourceProcessor

fix datasource bug -> connect OK

[Improvement-15260][dolphinscheduler-datasource-hana] add hana  related dependencies (apache#15260)

* add hana related dependencies

* optimizing HANA data source bugs

* run mvn spotless:apply

* Fix hana datasource getValidationQuery()

* Fix hana datasource testGetJdbcUrl()

---------

Co-authored-by: xujiaqiang <“[email protected]”>
Co-authored-by: David Zollo <[email protected]>

[Feature-15248][dolphinscheduler-alert-plugins] add alert plugin aliyun-voice (apache#15248)

* add alert aliyun-voice

* VoiceParam replace these with lombok @DaTa

* security.ts add alarm_instance params

* optimize alert aliyun vocie code

* Merge Code

* rollback pnpm-lock.yaml to branch :origin/dev version

* add the doc about the new plugin

* add com.aliyun.dyvmsapi20170525 version 2.14

* completed

* run mvn spotless:apply

* Code optimization

* Change to @DaTa

* Code specification optimization

* add com.aliyund.yvmsapi20170525.jar license

* modify com.aliyund.yvmsapi20170525.jar license

* modify com.aliyund.yvmsapi20170525.jar license

* add aliyun-vocie licenses

* add aliyun-voice link to docsdev.js

* modify vocie module to aliyunVoice

* add lisense

---------

Co-authored-by: xujiaqiang <“[email protected]”>
Co-authored-by: 旺阳 <[email protected]>
Co-authored-by: David Zollo <[email protected]>

[Feature-15146][dolphinscheduler-task-sqoop] add sqoop source/target type (apache#15146)

* task list: sgoop node params  optimize

* security.ts  add  alarm_instance params

* 1 add SqoopTask params
2 add alert plugin aliyun-voice

* add license header

* commit sqhoop optimize

* pnpm-locl.yaml supplement annotation

* remove irrelevent commit.

* Code specification optimization

* optimize sqoop task ui

* Merge Code

* add the license header to  pnpm-locl.yaml

* format the code

* format the code

* Fix sqoop task echo error

---------

Co-authored-by: xujiaqiang <[email protected]>
Co-authored-by: xujiaqiang <“[email protected]”>
Co-authored-by: David Zollo <[email protected]>

finishgit add dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/constants/DataSourceConstants.java

Fix k8sTaskExecutionContext setting configYaml (apache#15116)

* fixed the issue of obtaining kubeConfig of k8s tasks

* removed excess files

* removed excess files

* formatted the code

---------

Co-authored-by: xiangzihao <[email protected]>
Co-authored-by: Aaron Wang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend first time contributor First-time contributor improvement make more easy to user or prompt friendly ready-to-merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants