[Feature-14550][datasource-plugin] add HANA datasource-add pom.xml #14550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IT-Kwj
changed the title
SbloodyS
reviewed
Jul 21, 2023
Comment on lines
50
to
52
| <groupId>com.sap.cloud.db.jdbc</groupId> | ||
| <artifactId>ngdbc</artifactId> | ||
| <version>${ngdbc.version}</version> |
There was a problem hiding this comment.
After taking a quick look at Hana's license https://tools.hana.ondemand.com/developer-license-3_1.txt. It doesn't seem to comply with the Apache license.
There was a problem hiding this comment.
- could you please add sap jdbc to module bom like and use it in Hana pom
- and change scope due to not compatible reason
added 2 commits
July 28, 2023 10:26
zhongjiajie
reviewed
Jul 28, 2023
dolphinscheduler-datasource-plugin/dolphinscheduler-datasource-all/pom.xml
Show resolved
Hide resolved
dolphinscheduler-datasource-plugin/dolphinscheduler-datasource-hana/pom.xml
Outdated
Show resolved
Hide resolved
|
This pull request has been automatically marked as stale because it has not had recent activity for 120 days. It will be closed in 7 days if no further activity occurs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add HANA datasource-add pom.xml