Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix-13815][master] Fix dependent task incorrect timeout alerts #13822

Merged
merged 1 commit into from
Apr 19, 2023

Conversation

ralphgj
Copy link
Contributor

@ralphgj ralphgj commented Mar 29, 2023

Purpose of the pull request

close #13815

Brief change log

Fix dependent task incorrect timeout alerts

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

@ralphgj ralphgj changed the base branch from 3.1.5-prepare to dev March 30, 2023 06:32
@SbloodyS SbloodyS added bug Something isn't working 3.1.x for 3.1.x version labels Mar 31, 2023
@SbloodyS SbloodyS added this to the 3.1.6 milestone Mar 31, 2023
@ralphgj
Copy link
Contributor Author

ralphgj commented Apr 12, 2023

@SbloodyS Could you merge this pr or any other suggestions?

@codecov-commenter
Copy link

Codecov Report

Merging #13822 (1d07217) into dev (1e8d09e) will increase coverage by 0.03%.
The diff coverage is 21.15%.

❗ Current head 1d07217 differs from pull request most recent head 4a29a21. Consider uploading reports for the commit 4a29a21 to get more accurate results

@@             Coverage Diff              @@
##                dev   #13822      +/-   ##
============================================
+ Coverage     39.10%   39.13%   +0.03%     
+ Complexity     4440     4439       -1     
============================================
  Files          1132     1142      +10     
  Lines         42163    42004     -159     
  Branches       4746     4739       -7     
============================================
- Hits          16487    16439      -48     
+ Misses        23868    23761     -107     
+ Partials       1808     1804       -4     
Impacted Files Coverage Δ
.../dolphinscheduler/alert/AlertRequestProcessor.java 0.00% <0.00%> (-93.75%) ⬇️
...org/apache/dolphinscheduler/alert/AlertServer.java 0.00% <0.00%> (-45.95%) ⬇️
.../dolphinscheduler/api/aspect/CacheEvictAspect.java 5.12% <0.00%> (ø)
...low/instance/pause/pause/PauseExecuteFunction.java 0.00% <0.00%> (ø)
...or/workflow/instance/stop/StopExecuteFunction.java 0.00% <0.00%> (ø)
.../apache/dolphinscheduler/api/rpc/ApiRpcClient.java 60.00% <0.00%> (ø)
...er/api/service/impl/MetricsCleanUpServiceImpl.java 14.28% <0.00%> (ø)
...uler/api/service/impl/TaskInstanceServiceImpl.java 51.79% <0.00%> (ø)
...hinscheduler/common/constants/TenantConstants.java 0.00% <0.00%> (ø)
...apache/dolphinscheduler/common/utils/LogUtils.java 0.00% <0.00%> (ø)
... and 123 more

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@SbloodyS SbloodyS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@sonarcloud
Copy link

sonarcloud bot commented Apr 19, 2023

Please retry analysis of this Pull-Request directly on SonarCloud.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.1.x for 3.1.x version backend bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] [Master] Master sent incorrect timeout alerts for dependent tasks that were successfully executed
4 participants