[Bug] [Master] Master sent incorrect timeout alerts for dependent tasks that were successfully executed

[ralphgj]

Search before asking

• I had searched in the issues and found no similar issues.

What happened

I got timeout alerts ("Task Timeout Warn" and "Process Timeout Warn") from the alert server when I have dependent tasks in process definitions. But the dependent tasks with timeout alerts are all successfully executed.
The alert server is only responsible for receiving alerts. So I think the actual alerts should be generated by the master server.

What you expected to happen

No timeout alerts sent

How to reproduce

1. Prepare two process definitions，first process definition have one task, second process definition have two tasks.
2. The Second process definition have a dependent task which represent the task in the first process definition, and the timeout set to 1 minute.
3. Another task in the second process definition running time should more that 1 minute.

Anything else

No response

Version

3.1.x

Are you willing to submit PR?

• Yes I am willing to submit a PR!

Code of Conduct

• I agree to follow this project's Code of Conduct

[github-actions]

Thank you for your feedback, we have received your issue, Please wait patiently for a reply.

• In order for us to understand your request as soon as possible, please provide detailed information, version or pictures.
• If you haven't received a reply for a long time, you can join our slack and send your question to channel #troubleshooting

[ralphgj]

After debugging, I discovered that the dependent task was being added twice to the taskInstanceTimeoutCheckList.

Upon further investigation, I found that in the checkTask4Timeout method, the dependent task was not opening the timeout flag and would never be reached, even if it had already been added to the taskInstanceTimeoutCheckList.