Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Doc][Style] Fix doc format once for all #12006

Merged
merged 2 commits into from
Sep 17, 2022
Merged

[Doc][Style] Fix doc format once for all #12006

merged 2 commits into from
Sep 17, 2022

Conversation

EricGao888
Copy link
Member

Purpose of the pull request

Brief change log

  • Fix the format of docs once for all.

Verify this pull request

  • This PR is to fix doc format without test coverage needed.

@EricGao888 EricGao888 marked this pull request as ready for review September 16, 2022 17:04
@EricGao888 EricGao888 self-assigned this Sep 16, 2022
@EricGao888 EricGao888 added document improvement make more easy to user or prompt friendly labels Sep 16, 2022
@github-actions github-actions bot added backend CI&CD e2e e2e test Python test UI ui and front end related labels Sep 16, 2022
@codecov-commenter
Copy link

codecov-commenter commented Sep 16, 2022 •
edited
Loading

Codecov Report

Merging #12006 (9ae950b) into dev (5202e5c) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                dev   #12006      +/-   ##
============================================
- Coverage     38.67%   38.66%   -0.01%     
+ Complexity     4002     4000       -2     
============================================
  Files          1003     1003              
  Lines         36559    36559              
  Branches       4220     4220              
============================================
- Hits          14138    14136       -2     
  Misses        20817    20817              
- Partials       1604     1606       +2
Impacted Files Coverage Δ
...er/master/dispatch/host/assign/RandomSelector.java 77.77% <0.00%> (-5.56%) ⬇️
...pache/dolphinscheduler/common/utils/DateUtils.java 74.37% <0.00%> (-0.63%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

kezhenxu94
kezhenxu94 previously approved these changes Sep 17, 2022
View reviewed changes
SbloodyS
SbloodyS previously approved these changes Sep 17, 2022
View reviewed changes
Copy link
Member

@SbloodyS SbloodyS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@SbloodyS SbloodyS added this to the 3.1.0 milestone Sep 17, 2022
@kezhenxu94
Copy link
Member

Please fix the dead link

@ruanwenjun
Copy link
Member

ruanwenjun commented Sep 17, 2022 •
edited
Loading

Please cp this PR to 3.1.0-prepare after the ci pass.

@EricGao888
Copy link
Member Author

Please fix the dead link

Sure, thx

@EricGao888
Copy link
Member Author

Please cp this PR to 3.1.0-prepare after the ci pass.

Sure, will do.

@EricGao888 EricGao888 dismissed stale reviews from SbloodyS and kezhenxu94 via eba1c03 September 17, 2022 02:47
@sonarcloud
Copy link

sonarcloud bot commented Sep 17, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@kezhenxu94 kezhenxu94 merged commit a44817f into apache:dev Sep 17, 2022
@kezhenxu94 kezhenxu94 mentioned this pull request Sep 17, 2022
Closed
xdu-chenrj pushed a commit to xdu-chenrj/dolphinscheduler that referenced this pull request Sep 17, 2022
@EricGao888 @xdu-chenrj
[Doc][Style] Fix doc format once for all (apache#12006)
2a467b8
This was referenced Sep 21, 2022
Merged
Merged
@caishunfeng caishunfeng added the release cherry-pick Mark this issue/PR had cherry-pick for release version label Sep 23, 2022
xdu-chenrj pushed a commit to xdu-chenrj/dolphinscheduler that referenced this pull request Oct 13, 2022
@EricGao888 @xdu-chenrj
[Doc][Style] Fix doc format once for all (apache#12006)
94cd457
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kezhenxu94 kezhenxu94 kezhenxu94 approved these changes

@SbloodyS SbloodyS SbloodyS left review comments

@zhongjiajie zhongjiajie Awaiting requested review from zhongjiajie

@Tianqi-Dotes Tianqi-Dotes Awaiting requested review from Tianqi-Dotes

@songjianet songjianet Awaiting requested review from songjianet songjianet is a code owner

@Amy0104 Amy0104 Awaiting requested review from Amy0104

@caishunfeng caishunfeng Awaiting requested review from caishunfeng

@ruanwenjun ruanwenjun Awaiting requested review from ruanwenjun ruanwenjun is a code owner

Assignees

@EricGao888 EricGao888

Labels
backend CI&CD document e2e e2e test improvement make more easy to user or prompt friendly Python release cherry-pick Mark this issue/PR had cherry-pick for release version test UI ui and front end related
Projects
None yet
Milestone
3.1.0
Development

Successfully merging this pull request may close these issues.

[Doc][Style] Fix the format of all docs once for all
6 participants
@EricGao888 @codecov-commenter @kezhenxu94 @ruanwenjun @SbloodyS @caishunfeng