Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI][Doc] Add lint for markdown document #11695

Closed
wants to merge 5 commits into from
Closed

Conversation

hezean
Copy link
Contributor

@hezean hezean commented Aug 29, 2022

@hezean
Copy link
Contributor Author

hezean commented Aug 29, 2022

There are too many lint errors, I'll submit another PR to fix them

@github-actions github-actions bot added the CI&CD label Aug 29, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #11695 (17e0c43) into dev (145e441) will decrease coverage by 0.00%.
The diff coverage is n/a.

❗ Current head 17e0c43 differs from pull request most recent head 157d4e1. Consider uploading reports for the commit 157d4e1 to get more accurate results

@@             Coverage Diff              @@
##                dev   #11695      +/-   ##
============================================
- Coverage     39.81%   39.81%   -0.01%     
  Complexity     4718     4718              
============================================
  Files          1002     1002              
  Lines         37872    37872              
  Branches       4230     4230              
============================================
- Hits          15080    15077       -3     
- Misses        21191    21194       +3     
  Partials       1601     1601              
Impacted Files Coverage Δ
...erver/master/processor/queue/TaskEventService.java 75.00% <0.00%> (-5.36%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@SbloodyS SbloodyS added this to the 3.1.0 milestone Aug 30, 2022
@EricGao888 EricGao888 closed this Aug 30, 2022
@EricGao888 EricGao888 reopened this Aug 30, 2022
@EricGao888
Copy link
Member

Sorry, I closed it by mistake just now. I've reopened it. This one is great, it could save our time for reviewing and fixing docs manually.

@github-actions github-actions bot removed the document label Aug 30, 2022
@sonarcloud
Copy link

sonarcloud bot commented Aug 30, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@hezean
Copy link
Contributor Author

hezean commented Sep 2, 2022

@EricGao888 can we merge this PR first, and fix the lint errors in another PR? I think that may make review easier

@EricGao888
Copy link
Member

@EricGao888 can we merge this PR first, and fix the lint errors in another PR? I think that may make review easier

I'm fine with it. WDYT? @SbloodyS BTW, @hezean could you please add the key word related: #xxxxxxxx in another PR so that we could understand what another PR you are referring to.

Copy link
Member

@EricGao888 EricGao888 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I'm wondering whether there are any conflicts between spotless flexmark step and lint for markdown files? Have you experimented on it? @hezean

@kezhenxu94
Copy link
Member

LGTM, but I'm wondering whether there are any conflicts between spotless flexmark step and lint for markdown files? Have you experimented on it? @hezean

I prefer we use a single linter (spotless) to do the linting stuffs. It's easier for developers to verify locally and don't require another learning how superlinter works

@hezean
Copy link
Contributor Author

hezean commented Sep 14, 2022

Thanks for the suggestion! I totally agree on it and will take a look at spotless, whereas I'm busy preparing for an important exam recently, please give me some time before I can step back to this pr.

@EricGao888
Copy link
Member

LGTM, but I'm wondering whether there are any conflicts between spotless flexmark step and lint for markdown files? Have you experimented on it? @hezean

I prefer we use a single linter (spotless) to do the linting stuffs. It's easier for developers to verify locally and don't require another learning how superlinter works

+1

@EricGao888
Copy link
Member

Thanks for the suggestion! I totally agree on it and will take a look at spotless, whereas I'm busy preparing for an important exam recently, please give me some time before I can step back to this pr.

@hezean Good luck with the exam : )

@kezhenxu94
Copy link
Member

Is this fixed by #12006?

@caishunfeng caishunfeng removed this from the 3.1.0 milestone Sep 27, 2022
@hezean
Copy link
Contributor Author

hezean commented Dec 5, 2022

closing this outdated pr as finished in #12977

@hezean hezean closed this Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature][Doc] Add lint for markdown document
6 participants