-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI][Doc] Add lint for markdown document #11695
Conversation
There are too many lint errors, I'll submit another PR to fix them |
Codecov Report
@@ Coverage Diff @@
## dev #11695 +/- ##
============================================
- Coverage 39.81% 39.81% -0.01%
Complexity 4718 4718
============================================
Files 1002 1002
Lines 37872 37872
Branches 4230 4230
============================================
- Hits 15080 15077 -3
- Misses 21191 21194 +3
Partials 1601 1601
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sorry, I closed it by mistake just now. I've reopened it. This one is great, it could save our time for reviewing and fixing docs manually. |
Kudos, SonarCloud Quality Gate passed! |
@EricGao888 can we merge this PR first, and fix the lint errors in another PR? I think that may make review easier |
I'm fine with it. WDYT? @SbloodyS BTW, @hezean could you please add the key word |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but I'm wondering whether there are any conflicts between spotless flexmark step
and lint
for markdown files? Have you experimented on it? @hezean
I prefer we use a single linter (spotless) to do the linting stuffs. It's easier for developers to verify locally and don't require another learning how superlinter works |
Thanks for the suggestion! I totally agree on it and will take a look at spotless, whereas I'm busy preparing for an important exam recently, please give me some time before I can step back to this pr. |
+1 |
@hezean Good luck with the exam : ) |
Is this fixed by #12006? |
closing this outdated pr as finished in #12977 |
Purpose of the pull request
Resolves #8391
Ex. see https://github.com/HeZean/dolphinscheduler/actions/runs/2949741507