Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] [WEBSITE-9279] fix parameter priority documentation #753

Merged
merged 3 commits into from
Mar 31, 2022
Merged

[FIX] [WEBSITE-9279] fix parameter priority documentation #753

merged 3 commits into from
Mar 31, 2022

Conversation

Tianqi-Dotes
Copy link
Member

fix parameter priority documentation

@Tianqi-Dotes
Copy link
Member Author

The author of this PR is @wangxj3 , thanks to the contribution.

@Tianqi-Dotes
Copy link
Member Author

I will do the EN version fix when CN version review is done.

caishunfeng
caishunfeng reviewed Mar 30, 2022
View reviewed changes
Copy link
Contributor

@caishunfeng caishunfeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

zh-cn is OK.

zhongjiajie
zhongjiajie previously approved these changes Mar 30, 2022
View reviewed changes
Copy link
Member

@zhongjiajie zhongjiajie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

zhongjiajie
zhongjiajie approved these changes Mar 31, 2022
View reviewed changes
Copy link
Member

@zhongjiajie zhongjiajie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@zhongjiajie zhongjiajie merged commit c48b5b5 into apache:master Mar 31, 2022
@Tianqi-Dotes Tianqi-Dotes mentioned this pull request Apr 5, 2022
Closed
3 tasks
@Tianqi-Dotes Tianqi-Dotes mentioned this pull request Apr 14, 2022
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caishunfeng caishunfeng caishunfeng left review comments

@zhongjiajie zhongjiajie zhongjiajie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Tianqi-Dotes @caishunfeng @zhongjiajie