Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] [Parameter Context] The problem of global parameter priority #8329

Closed
3 tasks done
cheneychoi opened this issue Feb 10, 2022 · 11 comments
Closed
3 tasks done

[Bug] [Parameter Context] The problem of global parameter priority #8329

cheneychoi opened this issue Feb 10, 2022 · 11 comments
Labels
bug Something isn't working discussion discussion document major Stale

Comments

@cheneychoi
Copy link
Contributor

Search before asking

  • I had searched in the issues and found no similar issues.

What happened

在kai fa we开发文档中,全局参数localParam的优先级是最低的,如图
image
我在测试中发现,localParam会优先级更高,下图是测试结果
image
image
image

What you expected to happen

最后打印出x的值应该为varpool中的lll,而不是localparam中的2

How to reproduce

按照我上面的定义即可以重新复现

Anything else

No response

Version

2.0.2

Are you willing to submit PR?

  • Yes I am willing to submit a PR!

Code of Conduct

@cheneychoi cheneychoi added bug Something isn't working Waiting for reply Waiting for reply labels Feb 10, 2022
@github-actions github-actions bot changed the title [Bug] [Parameter Context] 全局参数优先级的问题 [Bug] [Parameter Context] The problem of global parameter priority Feb 10, 2022
@github-actions
Copy link

Search before asking

  • I had searched in the issues and found no similar issues.

What happened

In the kai fa we development document, the global parameter localParam has the lowest priority, as shown in the figure
image
I found in the test that localParam will have a higher priority, the following picture is the test result
image
image
image

What you expected to happen

Finally print out the value of x should be lll in varpool, not 2 in localparam

How to reproduce

It can be reproduced according to my definition above

Anything else

No response

Version

2.0.2

Are you willing to submit PR?

  • Yes I am willing to submit a PR!

Code of Conduct

@github-actions
Copy link

Hi:

  • Thank you for your feedback, we have received your issue, Please wait patiently for a reply.
  • In order for us to understand your request as soon as possible, please provide detailed information、version or pictures.
  • If you haven't received a reply for a long time, you can subscribe to the developer's email,Mail subscription steps reference https://dolphinscheduler.apache.org/en-us/community/development/subscribe.html ,Then write the issue URL in the email content and send question to [email protected].

@jim-parsons
Copy link
Contributor

i tried on latest dev code and got the same result

image

image

image

@cheneychoi
Copy link
Contributor Author

我已经修改了问题,提交了pr,暂时还没有得到回复!

@zhongjiajie
Copy link
Member

I am not sure this issue is bug for code or for document, could you please take a look? @lenboo @caishunfeng . I think is it important for both codebase or document bug, so I add label core

@zhongjiajie
Copy link
Member

IMO, I thinks it more like our documentation is out up date, and should be upgrade

@zhongjiajie zhongjiajie added the discussion discussion label Feb 11, 2022
@github-actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity for 30 days. It will be closed in next 7 days if no further activity occurs.

@github-actions github-actions bot added the Stale label Mar 14, 2022
@zhongjiajie
Copy link
Member

Remove stale

@github-actions github-actions bot removed the Stale label Mar 15, 2022
@github-actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity for 30 days. It will be closed in next 7 days if no further activity occurs.

@github-actions github-actions bot added the Stale label Apr 14, 2022
@caishunfeng
Copy link
Contributor

PTAL @Tianqi-Dotes

@Tianqi-Dotes
Copy link
Member

the 2.0.5 and version below 2.0.5 doc illustrate the wrong priorities, please check the dev doc.
https://dolphinscheduler.apache.org/zh-cn/docs/dev/user_doc/guide/parameter/priority.html

Have fixed both the doc and code,please refer to following:
doc:apache/dolphinscheduler-website#753
code:#9379

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working discussion discussion document major Stale
Projects
None yet
Development

No branches or pull requests

5 participants