feat: support the ergonomics of getting list slice with stride

[Weijun-H]

Which issue does this PR close?

Closes #8830

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

[Weijun-H]

sqlparser-rs does not support these syntax.

❯ select [1,2,3][-1:-3:-2];  🤔 Invalid statement: sql parser error: Expected a value, found: -
❯ select [1,2,3][-1:-3];  🤔 Invalid statement: sql parser error: Expected a value, found: -

[jayzhan211]

sqlparser-rs does not support these syntax.

❯ select [1,2,3][-1:-3:-2];  🤔 Invalid statement: sql parser error: Expected a value, found: -
❯ select [1,2,3][-1:-3];  🤔 Invalid statement: sql parser error: Expected a value, found: -

This is not valid in duckdb too, try select ([1,2,3])[-1:-3]

[alamb]

Hi @Weijun-H -- I wonder if you know of another database that offers this method of accessing lists?

[Weijun-H]

Hi @Weijun-H -- I wonder if you know of another database that offers this method of accessing lists?

I only know DuckDB: https://duckdb.org/docs/sql/functions/nested.html#slicing @alamb

[Weijun-H]

sqlparser-rs does not support these syntax.

❯ select [1,2,3][-1:-3:-2];  🤔 Invalid statement: sql parser error: Expected a value, found: -
❯ select [1,2,3][-1:-3];  🤔 Invalid statement: sql parser error: Expected a value, found: -

This is not valid in duckdb too, try select ([1,2,3])[-1:-3]

This Is the problem of sqlparser-rs, apache/datafusion-sqlparser-rs#1108.

[jayzhan211]

It is unused in this PR, and I think we might not need it too, since new_range is only used in test, which may be removed in the future since we can test them in slt.

[jayzhan211]

One small thing, I think stride is equivalent to step, IMO ListRange is more appropriate than ListStride

[jayzhan211]

nit:

                let (start, stop, stride) = if let SQLExpr::JsonAccess { left: l, operator: JsonOperator::Colon, right: r } = *left {
                    let start = Box::new(self.sql_expr_to_logical_expr(*l, schema, planner_context)?);
                    let stop = Box::new(self.sql_expr_to_logical_expr(*r, schema, planner_context)?);
                    let stride = Box::new(self.sql_expr_to_logical_expr(*right, schema, planner_context)?);
                    (start, stop, stride)
                } else {
                    let start = Box::new(self.sql_expr_to_logical_expr(*left, schema, planner_context)?);
                    let stop = Box::new(self.sql_expr_to_logical_expr(*right, schema, planner_context)?);
                    let stride = Box::new(Expr::Literal(ScalarValue::Int64(Some(1))));
                    (start, stop, stride)
                };
                GetFieldAccess {
                    start,
                    stop,
                    stride
                }

[jayzhan211]

LGTM, left some minor comments

[alamb]

Thank you @Weijun-H and @jayzhan211 🚀

[alamb]

👍

[alamb]

I think the clippy failure

https://github.com/apache/arrow-datafusion/actions/runs/7690817195/job/20955254027

was fixed by @viirya in #9034