Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename ParamValues::{LIST -> List,MAP -> Map} #8611

Merged
merged 2 commits into from
Dec 22, 2023

Conversation

kawadakk
Copy link
Contributor

Which issue does this PR close?

Closes #8610.

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree this is a nice improvement. Thank you @kawadakk
cc @Asura7969

@alamb alamb added the api change Changes the API exposed to users of the crate label Dec 21, 2023
@alamb
Copy link
Contributor

alamb commented Dec 21, 2023

Marking as API change as the names of the enum are pub

@Asura7969
Copy link
Contributor

this looks great❤️

@alamb alamb merged commit 0e62fa4 into apache:main Dec 22, 2023
22 checks passed
@alamb
Copy link
Contributor

alamb commented Dec 22, 2023

Thanks again @kawadakk

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api change Changes the API exposed to users of the crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ParamValues::{LIST,MAP} does not conform to the standard naming convention
3 participants