Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ParamValues::{LIST,MAP} does not conform to the standard naming convention #8610

Closed
kawadakk opened this issue Dec 21, 2023 · 0 comments · Fixed by #8611
Closed

ParamValues::{LIST,MAP} does not conform to the standard naming convention #8610

kawadakk opened this issue Dec 21, 2023 · 0 comments · Fixed by #8611
Labels
bug Something isn't working

Comments

@kawadakk
Copy link
Contributor

kawadakk commented Dec 21, 2023 •
edited
Loading

Describe the bug

The standard naming convention (RFC 430) says enum variants should be named by UpperCamelCase. Most existing enum types in DataFusion conform to this convention, but ParamValues does not.

To Reproduce

No response

Expected behavior

No response

Additional context

No response
@kawadakk kawadakk added the bug Something isn't working label Dec 21, 2023
@kawadakk kawadakk mentioned this issue Dec 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rename ParamValues::{LIST -> List,MAP -> Map} kawadakk/arrow-datafusion
1 participant
@kawadakk