Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor: Port tests in displayable.rs to sqllogictest #8246

Merged
merged 2 commits into from
Nov 17, 2023
Merged

Conversation

Weijun-H
Copy link
Member

@Weijun-H Weijun-H commented Nov 17, 2023

Which issue does this PR close?

Closes #8198

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

@github-actions github-actions bot added the core Core DataFusion crate label Nov 17, 2023
Comment on lines -46 to -51
assert_eq!("CoalesceBatchesExec: target_batch_size=8192\
\n FilterExec: a@0 < 5\
\n RepartitionExec: partitioning=RoundRobinBatch(3), input_partitions=1\
\n CsvExec: file_groups={1 group: [[WORKING_DIR/tests/data/example.csv]]}, projection=[a], has_header=true",
plan_string.trim());

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@comphead comphead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks @Weijun-H

@alamb
Copy link
Contributor

alamb commented Nov 17, 2023

Thanks @Weijun-H and @comphead

@alamb alamb merged commit c14a765 into apache:main Nov 17, 2023
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Core DataFusion crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Port tests in describe.rs to sqllogictest
3 participants