Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port tests in displayable.rs to sqllogictest #8199

Closed
Tracked by #6195
alamb opened this issue Nov 15, 2023 · 3 comments
Closed
Tracked by #6195

Port tests in displayable.rs to sqllogictest #8199

alamb opened this issue Nov 15, 2023 · 3 comments
Labels
good first issue Good for newcomers

Comments

@alamb
Copy link
Contributor

alamb commented Nov 15, 2023

Part of #6195. We are trying to

  1. keep the DataFusion code base clean and easy to contribute to and modify
  2. Understand what features are covered and what are not

Part of doing so is having a single location for most test coverage so new tests can be added easily and people can follow the existing patterns easily

Describe the solution you'd like

Port the tests in https://github.com/apache/arrow-datafusion/blob/main/datafusion/core/tests/sql/displayable.rs to
displayable.slt in https://github.com/apache/arrow-datafusion/tree/main/datafusion/sqllogictest/test_files

Note you can create catalogs and schema via SQL now

Catalogs: https://arrow.apache.org/datafusion/user-guide/sql/ddl.html#create-database
Schema: https://arrow.apache.org/datafusion/user-guide/sql/ddl.html#create-schema

Notes:

  1. Instructions for running sqllogitest are here: https://github.com/apache/arrow-datafusion/tree/main/datafusion/sqllogictest

Describe alternatives you've considered

No response

Additional context

I think these are good first issues as they teach the contributor about the DataFusion codebase and tests, as well as see the end user apis in practice.

@alamb
Copy link
Contributor Author

alamb commented Nov 15, 2023

I actually think this test may be covered by explain.slt already

@simicd
Copy link
Contributor

simicd commented Jan 21, 2024

Hi @alamb, I looked into this and it seems displayable.rs was already migrated with #8246, there is no such file anymore in the test folder. I think this issue can be closed as resolved.

@alamb
Copy link
Contributor Author

alamb commented Jan 21, 2024

Hi @alamb, I looked into this and it seems displayable.rs was already migrated with #8246, there is no such file anymore in the test folder. I think this issue can be closed as resolved.

Thank you @simicd -- I think you are right. Closing!

@alamb alamb closed this as completed Jan 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants