Specialize Median Accumulator #7376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tustvold
commented
Aug 22, 2023
| .with_expected_errors(vec![ | ||
| "Resources exhausted: Failed to allocate additional", | ||
| "AggregateStream", | ||
| ]) | ||
| .with_memory_limit(20_000) | ||
| .with_memory_limit(2_000) |
There was a problem hiding this comment.
We need to lower this memory limit, as it is significantly more space-efficient now
tustvold
commented
Aug 22, 2023
| @@ -68,12 +68,12 @@ async fn oom_sort() { | |||
| #[tokio::test] | |||
| async fn group_by_none() { | |||
| TestCase::new() | |||
| .with_query("select median(image) from t") | |||
| .with_query("select median(request_bytes) from t") | |||
There was a problem hiding this comment.
Changed to request_bytes as median isn't well defined for string types, this would only "work" if there happened to be an odd number of values, or the query errored (as in this case)
❯ create table test(c varchar) as values ('foo'), ('world'), ('hello');
0 rows in set. Query took 0.005 seconds.
❯ select median(c) from test;
+----------------+
| MEDIAN(test.c) |
+----------------+
| hello |
+----------------+
1 row in set. Query took 0.005 seconds.
❯ insert into test values ('bar');
+-------+
| count |
+-------+
| 1 |
+-------+
1 row in set. Query took 0.002 seconds.
❯ select median(c) from test;
Internal error: Operator + is not implemented for types Utf8("foo") and Utf8("hello"). This was likely caused by a bug in DataFusion's code and we would welcome that you file an bug report in our issue tracker
Dandandan
reviewed
Aug 22, 2023
| data_type: DataType, | ||
| arrays: Vec<ArrayRef>, | ||
| all_values: Vec<ScalarValue>, | ||
| all_values: Vec<T::Native>, |
Dandandan
reviewed
Aug 22, 2023
| None | ||
| } else if len % 2 == 0 { | ||
| let (low, high, _) = d.select_nth_unstable_by(len / 2, cmp); | ||
| let (_, low, _) = low.select_nth_unstable_by(low.len() - 1, cmp); |
Dandandan
approved these changes
Aug 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #6842
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?