Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make it able to specify a session id for SessionState #4933

Merged
merged 1 commit into from
Jan 17, 2023
Merged

Make it able to specify a session id for SessionState #4933

merged 1 commit into from
Jan 17, 2023

Conversation

yahoNanJing
Copy link
Contributor

Which issue does this PR close?

Closes #4920.

Rationale for this change

When using the Datafusion in the distributed engine, Ballista, a session will be created at the server side. While for the client, it will get a session id as the response. Then the client and the server will communicate with each other with specifying the session id as the key for the session state. Therefore, it's necessary to create a session state with specifying a session id at the Ballista client side.

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

@yahoNanJing yahoNanJing requested a review from alamb January 17, 2023 06:30
@github-actions github-actions bot added the core Core DataFusion crate label Jan 17, 2023
@yahoNanJing yahoNanJing requested a review from andygrove January 17, 2023 06:30
@alamb alamb merged commit 4e08117 into apache:master Jan 17, 2023
@ursabot
Copy link

ursabot commented Jan 17, 2023

Benchmark runs are scheduled for baseline = 9301133 and contender = 4e08117. 4e08117 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@andygrove andygrove mentioned this pull request Jan 17, 2023
Closed
1 task
andygrove pushed a commit to andygrove/datafusion that referenced this pull request Jan 17, 2023
@yahoNanJing @kyotoYaho @andygrove
Make it able to specify a session id for SessionState (apache#4933)
58f2359 
Co-authored-by: yangzhong <[email protected]>
alamb pushed a commit that referenced this pull request Jan 17, 2023
@andygrove @yahoNanJing @kyotoYaho
Make it able to specify a session id for SessionState (#4933) (#4951)
cecc127 
Co-authored-by: yangzhong <[email protected]>

Co-authored-by: yahoNanJing <[email protected]>
Co-authored-by: yangzhong <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alamb alamb alamb approved these changes

@andygrove andygrove Awaiting requested review from andygrove

Assignees
No one assigned
Labels
core Core DataFusion crate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ballista cannot upgrade to DataFusion 16 due to API changes
4 participants
@yahoNanJing @ursabot @alamb @kyotoYaho