Always increment timer on record #2298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tustvold
force-pushed
the
timer-always-increment
branch
from
2061877 to
cef7f09
Compare
|
ITS TOO FAST! |
|
Thanks for the fixing! I found this test flaky and added the assertion failure message in #2261 but failed to reproduce it in later trials. Previous failure before the assertion log: |
|
I manually rerun all failure checks for the latest PRs because of this flaky test. |
mcheshkov
pushed a commit
to cube-js/arrow-datafusion
that referenced
this pull request
Aug 22, 2024
Can drop this after rebase on commit baa2a36 "Always increment timer on record (apache#2298)", first released in 8.0.0
mcheshkov
pushed a commit
to cube-js/arrow-datafusion
that referenced
this pull request
Aug 30, 2024
Can drop this after rebase on commit baa2a36 "Always increment timer on record (apache#2298)", first released in 8.0.0
mcheshkov
pushed a commit
to cube-js/arrow-datafusion
that referenced
this pull request
Aug 30, 2024
Can drop this after rebase on commit baa2a36 "Always increment timer on record (apache#2298)", first released in 8.0.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
#2261 added a test that elapsed_compute was recorded in metrics, unfortunately in the case of LocalLimitExec and GlobalLimitExec the operator body is too small to reliable take time, and as such this test is flaky
Additionally when rendering plan metrics, a value if 0 is translated to "NOT RECORDED" - https://github.com/apache/arrow-datafusion/blob/master/datafusion/core/src/physical_plan/metrics/value.rs#L540
What changes are included in this PR?
This changes
Time::add_durationandTime::addto always record at least one nanosecond.Are there any user-facing changes?
Yes, calling
Timer::add_durationwill now always record at least 1 nanosecond