Introduce RowLayout to represent rows for different purposes #2261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yjshen
commented
Apr 18, 2022
| use std::sync::Arc; | ||
|
|
||
| const UTF8_DEFAULT_SIZE: usize = 20; | ||
| const BINARY_DEFAULT_SIZE: usize = 100; | ||
|
|
||
| #[derive(Copy, Clone, Debug)] |
There was a problem hiding this comment.
The main changes are below. Other files changes are almost mechanical.
andygrove
approved these changes
Apr 18, 2022
|
I plan to review this PR first thing tomorrow morning US eastern time (~ 6AM or so) |
alamb
approved these changes
Apr 19, 2022
| use std::sync::Arc; | ||
|
|
||
| const UTF8_DEFAULT_SIZE: usize = 20; | ||
| const BINARY_DEFAULT_SIZE: usize = 100; | ||
|
|
||
| #[derive(Copy, Clone, Debug)] | ||
| /// Type of a RowLayout | ||
| pub enum RowType { |
| @@ -85,52 +85,36 @@ macro_rules! fn_get_idx_opt { | |||
|
|
|||
| /// Read the tuple `data[base_offset..]` we are currently pointing to | |||
| pub struct RowReader<'a> { | |||
| /// Layout on how to read each field | |||
| @@ -96,51 +96,34 @@ macro_rules! fn_set_idx { | |||
|
|
|||
| /// Reusable row writer backed by Vec<u8> | |||
| pub struct RowWriter { | |||
| /// Layout on how to write each field | |||
alamb
approved these changes
Apr 20, 2022
| BooleanArray, | ||
| Boolean, | ||
| vec![Some(true), Some(false), None, Some(true), None], | ||
| WordAligned |
| offsets.push(offset); | ||
| offset += 8; // a 8-bytes word for each field | ||
| assert!(!matches!(f.data_type(), DataType::Decimal(_, _))); |
tustvold
reviewed
Apr 20, 2022
| "plan: {}", | ||
| DisplayableExecutionPlan::with_metrics(plan).one_line() | ||
| ); | ||
| assert!( |
There was a problem hiding this comment.
This change appears to be intermittently failing
https://github.com/apache/arrow-datafusion/runs/6100177086?check_suite_focus=true
https://github.com/apache/arrow-datafusion/runs/6100277301?check_suite_focus=true
https://github.com/apache/arrow-datafusion/runs/6100969854?check_suite_focus=true
Edit: This would appear to occur if the operator is too fast to record time passing, I'll get a PR up to fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
The second part of #2188.
Rationale for this change
To support an 8-byte aligned row layout for grouping states of hash aggregation.
What changes are included in this PR?
Enable the reading and writing raw-bytes rows with two possible layouts.
Are there any user-facing changes?
An API change might have no effects since it's on the optional feature
row.