Minor: Support protobuf serialization for Utf8View and BinaryView #12165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…calarValue::BinaryView
alamb
approved these changes
Sep 6, 2024
There was a problem hiding this comment.
Thank you @Lordworms -- I am sorry for the delay in reviewing this PR. I found one bug (see below) but clearly there was a gap in coverage.
Thus I took the liberty of fixing the issue and updating the tests as I had this checked out already.
Thanks again, and again sorry for the delay
| DataType::FixedSizeBinary(size) => Self::FixedSizeBinary(*size), | ||
| DataType::LargeBinary => Self::LargeBinary(EmptyMessage {}), | ||
| DataType::Utf8 => Self::Utf8(EmptyMessage {}), | ||
| DataType::Utf8View => Self::Utf8(EmptyMessage {}), |
There was a problem hiding this comment.
I think this should be Utf8View?
Suggested change
| DataType::Utf8View => Self::Utf8(EmptyMessage {}), | |
| DataType::Utf8View => Self::Utf8View(EmptyMessage {}), |
It is ok and welcome back! |
|
Thanks again @Lordworms |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…calarValue::BinaryView
Which issue does this PR close?
Closes #12117
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?