Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support protobuf serialization for ScalarValue::Utf8View and ScalarValue::BinaryView #12117

Closed
Tracked by #11752
alamb opened this issue Aug 22, 2024 · 1 comment · Fixed by #12165
Closed
Tracked by #11752

Support protobuf serialization for ScalarValue::Utf8View and ScalarValue::BinaryView #12117

alamb opened this issue Aug 22, 2024 · 1 comment · Fixed by #12165
Assignees
Labels
enhancement New feature or request

Comments

@alamb
Copy link
Contributor

alamb commented Aug 22, 2024

Is your feature request related to a problem or challenge?

Part of #11752

We are trying to enable DataFusion to use StringViewArray by default. If we do that it means ScalarValue::Utf8View and ScalarValue::BinaryView will be more likely to be used in plans

Describe the solution you'd like

Thus we need to ensure ScalarValue::Utf8View and ScalarValue::BinaryView can be serialized using datafusion-proto

Describe alternatives you've considered

I recommend adding coverage for ScalarValue::Utf8View and `ScalarValue::BinaryView to the tests here

ScalarValue::Utf8(Some(String::from("Test string "))),
ScalarValue::LargeUtf8(Some(String::from("Test Large utf8"))),

And then update the code to get the tests to pass

Additional context

No response

@alamb alamb added the enhancement New feature or request label Aug 22, 2024
@alamb alamb changed the title Support protobuf serialization for ScalarValue::Utf8View and `ScalarValue::BinaryView Support protobuf serialization for ScalarValue::Utf8View and ScalarValue::BinaryView Aug 22, 2024
@Lordworms
Copy link
Contributor

take

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants