Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable clone_on_ref_ptr clippy lint on optimizer #11346

Merged
merged 4 commits into from
Jul 10, 2024

Conversation

lewiszlw
Copy link
Member

@lewiszlw lewiszlw commented Jul 9, 2024

Which issue does this PR close?

Part of #11143. Code splited from #11157.

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

@github-actions github-actions bot added the optimizer Optimizer rules label Jul 9, 2024
Copy link
Contributor

@phillipleblanc phillipleblanc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've enabled this lint as well for our project and I agree its very helpful.

Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @lewiszlw and @phillipleblanc

@Dandandan Dandandan merged commit 146b679 into apache:main Jul 10, 2024
23 checks passed
@Dandandan
Copy link
Contributor

Thank you @lewiszlw

Lordworms pushed a commit to Lordworms/arrow-datafusion that referenced this pull request Jul 12, 2024
* Enable clone_on_ref_ptr clippy lint on optimizer

* Fix lints

* fmt
findepi pushed a commit to findepi/datafusion that referenced this pull request Jul 16, 2024
* Enable clone_on_ref_ptr clippy lint on optimizer

* Fix lints

* fmt
xinlifoobar pushed a commit to xinlifoobar/datafusion that referenced this pull request Jul 18, 2024
* Enable clone_on_ref_ptr clippy lint on optimizer

* Fix lints

* fmt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
optimizer Optimizer rules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants