Enable clone_on_ref_ptrclippy lint on some crates
#11157
Conversation
github-actions
bot
added
sql
lewiszlw
changed the title
clone_on_ref_ptr lintclone_on_ref_ptr lint on some crates
There was a problem hiding this comment.
Thank you @lewiszlw This is epic 🤖 🦾
I loaded all the diffs and skimmed them and they look good to me ❤️
I think this change makes the code more verbose, but explicit about where clones are doing a deep copy and where they are not
Also since this does not change any public APIs I think it is 👌 -- thank you for doing this
This might cause issues with people who have forked the code, but I don't see any way around that (other than of course having them contribute their changes back up stream)
cc @ozankabak
| @@ -14,6 +14,7 @@ | |||
| // KIND, either express or implied. See the License for the | |||
| // specific language governing permissions and limitations | |||
| // under the License. | |||
| #![deny(clippy::clone_on_ref_ptr)] | |||
alamb
changed the title
clone_on_ref_ptr lint on some cratesclone_on_ref_ptrclippy lint on some crates
|
This is a great change. However, instead of doing this in such a big PR, can we open an epic and do it in multiple small PRs one crate at a time? If possible, doing that will be much more friendly to fork owners. |
Co-authored-by: Andrew Lamb <[email protected]>
Which issue does this PR close?
part of #11143.
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?