Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move configuration information out of example usage page #11300

Merged
merged 2 commits into from
Jul 11, 2024

Conversation

alamb
Copy link
Contributor

@alamb alamb commented Jul 6, 2024

Which issue does this PR close?

Part of #11172

Rationale for this change

The current example usage page https://datafusion.apache.org/user-guide/example-usage.html contains a mix of getting started examples as well as more advanced options such as patching in new datafusion versions

Screenshot 2024-07-06 at 6 50 31 AM

I think this would be easier for people to find if they were split into two separate pages

What changes are included in this PR?

Move some of the more advanced usage examples to a new page called "Crate Configuration"

Screenshot 2024-07-06 at 6 52 18 AM Screenshot 2024-07-06 at 6 53 49 AM

Are these changes tested?

I manually looked at them

Are there any user-facing changes?

No, doc changes only

@github-actions github-actions bot added the core Core DataFusion crate label Jul 6, 2024
@@ -41,13 +41,16 @@ DataFusion offers SQL and Dataframe APIs, excellent
CSV, Parquet, JSON, and Avro, extensive customization, and a great
community.

To get started with examples, see the `example usage`_ section of the user guide and the `datafusion-examples`_ directory.
To get started, see
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also added a link to the library user guide as well as making this into a bullet list so it is easier to see what options are available

@alamb alamb marked this pull request as ready for review July 7, 2024 14:15
If you haven't reviewed the [architecture section in the docs][docs], it's a
useful place to get the lay of the land before starting down a specific path.

DataFusion is designed to be extensible at all points, including
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was random content that was on the "getting started" page that I moved into the library user guide as it seemed a bette rhome

@@ -33,29 +33,6 @@ datafusion = "latest_version"
tokio = { version = "1.0", features = ["rt-multi-thread"] }
```

## Add latest non published DataFusion dependency
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I moved all this content to other more appropriate locations

@alamb alamb marked this pull request as draft July 7, 2024 14:15
@alamb alamb marked this pull request as ready for review July 7, 2024 17:38
@alamb alamb added the documentation Improvements or additions to documentation label Jul 10, 2024
@github-actions github-actions bot removed the documentation Improvements or additions to documentation label Jul 10, 2024
Copy link
Member

@jonahgao jonahgao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!


## Enable backtraces

By default Datafusion returns errors as a plain message. There is option to enable more verbose details about the error,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
By default Datafusion returns errors as a plain message. There is option to enable more verbose details about the error,
By default DataFusion returns errors as a plain message. There is option to enable more verbose details about the error,

## Enable backtraces

By default Datafusion returns errors as a plain message. There is option to enable more verbose details about the error,
like error backtrace. To enable a backtrace you need to add Datafusion `backtrace` feature to your `Cargo.toml` file:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
like error backtrace. To enable a backtrace you need to add Datafusion `backtrace` feature to your `Cargo.toml` file:
like error backtrace. To enable a backtrace you need to add DataFusion `backtrace` feature to your `Cargo.toml` file:

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in #11439

@comphead comphead merged commit 0b2eb50 into apache:main Jul 11, 2024
24 checks passed
Lordworms pushed a commit to Lordworms/arrow-datafusion that referenced this pull request Jul 12, 2024
@alamb alamb deleted the alamb/simplify_usage branch July 12, 2024 18:14
@alamb
Copy link
Contributor Author

alamb commented Jul 12, 2024

Thanks for the review @jonahgao and merge @comphead 🙏

findepi pushed a commit to findepi/datafusion that referenced this pull request Jul 16, 2024
xinlifoobar pushed a commit to xinlifoobar/datafusion that referenced this pull request Jul 17, 2024
xinlifoobar pushed a commit to xinlifoobar/datafusion that referenced this pull request Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Core DataFusion crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants