-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move configuration information out of example usage page #11300
Conversation
@@ -41,13 +41,16 @@ DataFusion offers SQL and Dataframe APIs, excellent | |||
CSV, Parquet, JSON, and Avro, extensive customization, and a great | |||
community. | |||
|
|||
To get started with examples, see the `example usage`_ section of the user guide and the `datafusion-examples`_ directory. | |||
To get started, see |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also added a link to the library user guide as well as making this into a bullet list so it is easier to see what options are available
4f71a6d
to
53b2bea
Compare
If you haven't reviewed the [architecture section in the docs][docs], it's a | ||
useful place to get the lay of the land before starting down a specific path. | ||
|
||
DataFusion is designed to be extensible at all points, including |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was random content that was on the "getting started" page that I moved into the library user guide as it seemed a bette rhome
@@ -33,29 +33,6 @@ datafusion = "latest_version" | |||
tokio = { version = "1.0", features = ["rt-multi-thread"] } | |||
``` | |||
|
|||
## Add latest non published DataFusion dependency |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I moved all this content to other more appropriate locations
53b2bea
to
24027eb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
|
||
## Enable backtraces | ||
|
||
By default Datafusion returns errors as a plain message. There is option to enable more verbose details about the error, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By default Datafusion returns errors as a plain message. There is option to enable more verbose details about the error, | |
By default DataFusion returns errors as a plain message. There is option to enable more verbose details about the error, |
## Enable backtraces | ||
|
||
By default Datafusion returns errors as a plain message. There is option to enable more verbose details about the error, | ||
like error backtrace. To enable a backtrace you need to add Datafusion `backtrace` feature to your `Cargo.toml` file: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
like error backtrace. To enable a backtrace you need to add Datafusion `backtrace` feature to your `Cargo.toml` file: | |
like error backtrace. To enable a backtrace you need to add DataFusion `backtrace` feature to your `Cargo.toml` file: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done in #11439
Which issue does this PR close?
Part of #11172
Rationale for this change
The current example usage page https://datafusion.apache.org/user-guide/example-usage.html contains a mix of getting started examples as well as more advanced options such as patching in new datafusion versions
I think this would be easier for people to find if they were split into two separate pages
What changes are included in this PR?
Move some of the more advanced usage examples to a new page called "Crate Configuration"
Are these changes tested?
I manually looked at them
Are there any user-facing changes?
No, doc changes only