Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EPIC] Improve examples to make them easier to navigate #11172

Open
2 of 3 tasks
Tracked by #12740
alamb opened this issue Jun 28, 2024 · 4 comments
Open
2 of 3 tasks
Tracked by #12740

[EPIC] Improve examples to make them easier to navigate #11172

alamb opened this issue Jun 28, 2024 · 4 comments
Labels
documentation Improvements or additions to documentation enhancement New feature or request

Comments

@alamb
Copy link
Contributor

alamb commented Jun 28, 2024

Is your feature request related to a problem or challenge?

The current number of examples in https://github.com/apache/datafusion/tree/main/datafusion-examples is somewhat overwhelming and hard to navigate

Describe the solution you'd like

I would like fewer consolidated examples. For example a sql.rs example rather than SQL examples being spread out across (at least) 9 different files

  • parqet_sql
  • parqet_sql_multiple_files
  • regexp
  • to_char
  • to_date
  • to_timestamp
  • make_date
  • avro_sql.rs

Subtasks

Describe alternatives you've considered

No response

Additional context

Also, I am trying to add some new examples, but the CI in my PR #11088 is failing due to running out of space

Example failure: https://github.com/apache/datafusion/actions/runs/9715084012/job/26815819949

  = note: /usr/bin/ld: final link failed: No space left on device
          collect2: error: ld returned 1 exit status

I think it is because each example creates its own binary which fills up the disk

Thus I also want to reduce the number of examples so I can add new ones :)

@alamb alamb added documentation Improvements or additions to documentation enhancement New feature or request labels Jun 28, 2024
@alamb alamb self-assigned this Jun 28, 2024
@alamb
Copy link
Contributor Author

alamb commented Jun 29, 2024

While working with @lewiszlw in #11173 (comment) I think I came up with a better idea -- that is to update the user guide so they code examples are run / tested

Then we can move many/all of the examples from rust to the user guide, which will make them easier to find and navigate. 🏃

@alamb
Copy link
Contributor Author

alamb commented Jun 29, 2024

I played around with what we have and it turns out I think we can test examples in the user guide. I made a PR with docs of how to do it: #11178

I think with that framework we could add many of the simpler examples directly into the documentation where they would be eaiser to find. We can leave the more complex ones in datafusion-examples perhaps

Thoughts?

@efredine
Copy link
Contributor

As a newcomer I'll say that this seems right to me. Examples that are right in the documentation are much more discoverable.

@alamb alamb changed the title Consolidate examples to make them easier to navigate [EPIC] Improve examples to make them easier to navigate Jul 2, 2024
@alamb alamb removed their assignment Jul 15, 2024
@alamb
Copy link
Contributor Author

alamb commented Jul 15, 2024

I plan do to this as a background task, but realistically can't devote enough focus time to it now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants