Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace println! with assert! if possible in DataFusion examples #11230

Closed
Tracked by #11172
comphead opened this issue Jul 2, 2024 · 3 comments · Fixed by #11237
Closed
Tracked by #11172

Replace println! with assert! if possible in DataFusion examples #11230

comphead opened this issue Jul 2, 2024 · 3 comments · Fixed by #11237
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers

Comments

@comphead
Copy link
Contributor

comphead commented Jul 2, 2024

we can use assert! in DataFusion examples to let the user know the expected output

Originally posted by @comphead in #11088 (comment)

@alamb
Copy link
Contributor

alamb commented Jul 2, 2024

I added this as a subtask of #11230

I would like to propose we migrate some of the smaller examples over from datafusion-examples and into the user guide (to make them more discoverable)

Perhaps we can update them to use assert at the same time, as I found I had to do in #11217

@Nishi46
Copy link
Contributor

Nishi46 commented Jul 3, 2024

take

@ShreyasSN
Copy link

take

@Nishi46 Nishi46 removed their assignment Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants