Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dep: replace underscore w/ lodash module pkgs #193

Merged
merged 1 commit into from
Jan 12, 2023

Conversation

erisu
Copy link
Member

@erisu erisu commented Jan 12, 2023

Motivation and Context

Drop the entire underscore package.

Description

Only a few methods from the package was being used. To reduce the size footprint, I replaced with various lodash modules.

  • _.extend -> lodash.assign
  • _.isDate -> lodash.isdate
  • _.isObject -> lodash.isobject
  • _.zip -> lodash.zip

Testing

  • npm t

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

@erisu erisu added enhancement dependencies Pull requests that update a dependency file labels Jan 12, 2023
@erisu erisu added this to the 5.0.0 milestone Jan 12, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jan 12, 2023

Codecov Report

Merging #193 (cfefcd3) into master (b782a72) will increase coverage by 0.03%.
The diff coverage is 90.00%.

@@            Coverage Diff             @@
##           master     #193      +/-   ##
==========================================
+ Coverage   88.43%   88.46%   +0.03%     
==========================================
  Files          20       20              
  Lines        1141     1144       +3     
==========================================
+ Hits         1009     1012       +3     
  Misses        132      132              
Impacted Files Coverage Δ
src/superspawn.js 85.24% <50.00%> (ø)
src/util/plist-helpers.js 76.92% <100.00%> (+1.24%) ⬆️
src/util/xml-helpers.js 99.01% <100.00%> (+<0.01%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@erisu erisu changed the title refactor: replace underscore w/ lodash module pkgs dep: replace underscore w/ lodash module pkgs Jan 12, 2023
@erisu erisu marked this pull request as ready for review January 12, 2023 12:54
- _.extend -> lodash.assign
- _.isDate -> lodash.isdate
- _.isObject -> lodash.isobject
- _.zip -> lodash.zip
@erisu erisu merged commit e5d0899 into apache:master Jan 12, 2023
@erisu erisu deleted the dep/replace-underscore branch January 12, 2023 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants