refactor: replace underscore w/ lodash module pkgs

- _.extend -> lodash.assign
- _.isDate -> lodash.isdate
- _.isObject -> lodash.isobject
- _.zip -> lodash.zip

package.json

@@ -26,11 +26,14 @@
     "fast-glob": "^3.2.2",
     "fs-extra": "^9.0.0",
     "glob": "^7.1.6",
+    "lodash.assign": "^4.2.0",
+    "lodash.isdate": "^4.0.1",
+    "lodash.isobject": "^3.0.2",
+    "lodash.zip": "^4.2.0",
     "plist": "^3.0.1",
     "q": "^1.5.1",
     "read-chunk": "^3.2.0",
-    "strip-bom": "^4.0.0",
-    "underscore": "^1.9.2"
+    "strip-bom": "^4.0.0"
   },
   "devDependencies": {
     "@cordova/eslint-config": "^3.0.0",

src/superspawn.js

@@ -19,7 +19,7 @@
 
 const crossSpawn = require('cross-spawn');
 const fs = require('fs-extra');
-const _ = require('underscore');
+const extend = require('lodash.assign');
 const Q = require('q');
 const events = require('./events');
 const iswin32 = process.platform === 'win32';
@@ -73,7 +73,7 @@ exports.spawn = (cmd, args, opts) => {
     }
 
     if (opts.env) {
-        spawnOpts.env = _.extend(_.extend({}, process.env), opts.env);
+        spawnOpts.env = extend(extend({}, process.env), opts.env);
     }
 
     if (opts.chmod && !iswin32) {

src/util/plist-helpers.js

@@ -18,7 +18,9 @@
 */
 
 // contains PLIST utility functions
-const _ = require('underscore');
+const isObject = require('lodash.isobject');
+const isDate = require('lodash.isdate');
+const extend = require('lodash.assign');
 const plist = require('plist');
 
 // adds node to doc at selector
@@ -33,8 +35,8 @@ function graftPLIST (doc, xml, selector) {
     } else {
         // plist uses objects for <dict>. If we have two dicts we merge them instead of
         // overriding the old one. See CB-6472
-        const isDict = o => _.isObject(o) && !_.isDate(o); // arrays checked above
-        if (isDict(node) && isDict(obj)) _.extend(obj, node);
+        const isDict = o => isObject(o) && !isDate(o); // arrays checked above
+        if (isDict(node) && isDict(obj)) extend(obj, node);
 
         doc[selector] = obj;
     }

src/util/xml-helpers.js

@@ -25,7 +25,8 @@
 
 const fs = require('fs-extra');
 const path = require('path');
-const _ = require('underscore');
+const extend = require('lodash.assign');
+const zip = require('lodash.zip');
 const et = require('elementtree');
 const stripBom = require('strip-bom');
 
@@ -49,7 +50,7 @@ module.exports = {
             one.len() === two.len() &&
             String(one.text).trim() === String(two.text).trim() &&
             attribMatch(one, two) &&
-            _.zip(one.getchildren(), two.getchildren())
+            zip(one.getchildren(), two.getchildren())
                 .every(([c1, c2]) => module.exports.equalNodes(c1, c2));
     },
 
@@ -158,7 +159,7 @@ module.exports = {
         if (!target) return false;
 
         if (xml.oldAttrib) {
-            target.attrib = _.extend({}, xml.oldAttrib);
+            target.attrib = extend({}, xml.oldAttrib);
         }
 
         return true;