LANG-1752 seperated test cases of Strings from StringUtils #1279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -37,54 +34,22 @@ public class StringUtilsContainsTest extends AbstractLangTest { | |||
| public void testContains_Char() { | |||
| assertFalse(StringUtils.contains(null, ' ')); | |||
| assertFalse(StringUtils.contains("", ' ')); | |||
| assertFalse(StringUtils.contains("", null)); | |||
There was a problem hiding this comment.
@MSaifAsif
Do NOT delete existing tests please.
There was a problem hiding this comment.
I migrated it over here. Would you prefer that we keep the existing StringUtils test cases as well on top of the separation that I did ?
I haven't deleted any test case, they are just migrated over. I went through all the pre-existing test cases that were now showing deprecated api usage and migrated them over to the Strings related test cases. The test count should be the same as before, in fact should be more (since new test classes were made)
|
Reverted back the existing test cases @garydgregory I thought about it and yes its too risky of a move to not keep them. Reverted them back |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Separated out test cases from StringUtils. Added more cases for null check, it seems that we are running into a NPE when we use the new
Strings.CS.equals(null,null)method. See line where I created a test cases to highlight the failure. When usingStringUtils.equals(null, null)it doesn't throw a NPE. IMO We should use the same functionality when using either of theStrings.CSorStrings.CIequals method