Feature/509 remove install of v2 headers

CHANGES.md

@@ -19,6 +19,16 @@ See the License for the specific language governing permissions and
 limitations under the License.
 -->
 
+# Noteworthy Changes for 3.0.0 (TBD)
+
+## Backwards incompatible changes
+
+- Celix C API without a `celix_` is removed from the utils and framework lib and no longer supported.
+- Shell v2 api is removed and no longer supported.
+- Logging v2 api is removed and no longer supported.
+- Bonjour Shell bundle is removed and no longer supported.
+- pubsub_serializer.h is removed and no longer supported. Use pubsub_message_serialization_service.h instead. 
+
 # Noteworthy Changes for 2.4.0 (2023-09-27)
 
 ## New Features

CMakeLists.txt

@@ -157,7 +157,6 @@ if (ENABLE_TESTING)
     enable_testing()
 endif()
 
-option(CELIX_INSTALL_DEPRECATED_API "whether to install (and use) deprecated apis (i.e. header without a celix_ prefix." ON)
 option(CELIX_USE_ZIP_INSTEAD_OF_JAR "Default Celix cmake command will use jar to package bundle (if found). This option enforces Celix to use zip instead." OFF)
 
 option(CELIX_CXX14 "Build C++14 libraries and bundles. Note for tests C++ is always used." ON)
@@ -170,9 +169,9 @@ option(ENABLE_TESTING_DEPENDENCY_MANAGER_FOR_CXX11 "Test the Dependency Manager
 option(ENABLE_TESTING_FOR_CXX14 "Test celix utils and framework C++ header for C++14 support" OFF)
 option(ENABLE_CMAKE_WARNING_TESTS "Enable cmake warning tests to test warning prints" OFF)
 option(ENABLE_TESTING_ON_CI "Whether to enable testing on CI. This influence allowed timing errors during unit tests" OFF)
+option(ENABLE_DEPRECATED_WARNINGS "Enable compiler warnings for usage of deprecated functionality" OFF)
 
-if (CELIX_INSTALL_DEPRECATED_API)
-    #ignore deprecated warnings
+if (NOT ENABLE_DEPRECATED_WARNINGS)
     set(CMAKE_C_FLAGS "-Wno-deprecated-declarations ${CMAKE_C_FLAGS}")
     set(CMAKE_CXX_FLAGS "-Wno-deprecated-declarations ${CMAKE_CXX_FLAGS}")
 endif ()

bundles/logging/CMakeLists.txt

@@ -21,12 +21,6 @@ add_subdirectory(log_helper)
 
 celix_subproject(LOG_SERVICE "Option to enable building the Log Service bundles" ON)
 if (LOG_SERVICE)
-    #Version 2 API (deprecated)
-    if (CELIX_INSTALL_DEPRECATED_API)
-        add_subdirectory(log_service_v2)
-    endif ()
-
-    #Version 3 API
     add_subdirectory(log_admin)
     add_subdirectory(log_writers)
 endif ()

bundles/logging/log_helper/CMakeLists.txt

@@ -17,26 +17,13 @@
 
 celix_subproject(LOG_HELPER "Option to enable building the log helper library" ON)
 if (LOG_HELPER)
-    if (CELIX_INSTALL_DEPRECATED_API)
-        set(SOURCES src/celix_log_helper.c src/log_helper.c)
-    else ()
-        set(SOURCES src/celix_log_helper.c)
-    endif ()
-
-    add_library(log_helper STATIC ${SOURCES})
+    add_library(log_helper STATIC src/celix_log_helper.c)
     set_target_properties(log_helper PROPERTIES OUTPUT_NAME "celix_log_utils")
     target_include_directories(log_helper PUBLIC
             $<BUILD_INTERFACE:${CMAKE_CURRENT_LIST_DIR}/include>
             )
     target_link_libraries(log_helper PUBLIC Celix::log_service_api Celix::framework PRIVATE Celix::utils)
 
-    if (CELIX_INSTALL_DEPRECATED_API)
-        target_include_directories(log_helper PUBLIC
-                $<BUILD_INTERFACE:${CMAKE_CURRENT_LIST_DIR}/include_v1>
-                )
-        install(DIRECTORY include_v1/ DESTINATION ${CMAKE_INSTALL_INCLUDEDIR}/celix/log_helper)
-    endif ()
-
     install(TARGETS log_helper EXPORT celix DESTINATION ${CMAKE_INSTALL_LIBDIR} COMPONENT logging
             INCLUDES DESTINATION ${CMAKE_INSTALL_INCLUDEDIR}/celix/log_helper)
     install(DIRECTORY include/ DESTINATION ${CMAKE_INSTALL_INCLUDEDIR}/celix/log_helper COMPONENT logging)

bundles/logging/log_service_api/CMakeLists.txt

@@ -23,14 +23,6 @@ if (LOG_SERVICE_API)
             )
     target_link_libraries(log_service_api INTERFACE Celix::utils)
 
-    if (CELIX_INSTALL_DEPRECATED_API)
-        target_link_libraries(log_service_api INTERFACE Celix::framework)
-        target_include_directories(log_service_api INTERFACE
-                $<BUILD_INTERFACE:${CMAKE_CURRENT_LIST_DIR}/include_v2>
-                )
-        install(DIRECTORY include_v2/ DESTINATION ${CMAKE_INSTALL_INCLUDEDIR}/celix/log_service)
-    endif ()
-
     install(TARGETS log_service_api EXPORT celix
             INCLUDES DESTINATION ${CMAKE_INSTALL_INCLUDEDIR}/celix/log_service)
     install(DIRECTORY include/ DESTINATION ${CMAKE_INSTALL_INCLUDEDIR}/celix/log_service)