-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/509 remove install of v2 headers #666
Conversation
# Conflicts: # CHANGES.md
Codecov Report
@@ Coverage Diff @@
## master #666 +/- ##
==========================================
+ Coverage 81.55% 83.01% +1.45%
==========================================
Files 260 252 -8
Lines 34677 32789 -1888
==========================================
- Hits 28281 27219 -1062
+ Misses 6396 5570 -826
... and 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I used Celix in my day job. IIRC, we used some deprecated APIs for some reasons.
Before merging this PR, I would like to have a case-by-case analysis of these usages to make sure our new API can still satisfy these needs. For example, why service_reference
is needed for RSA? Without service_reference
, how to implement the same functionality with 3.0 API? More deprecated API usage scenarios will be added next week.
If the current 3.0 API can not address some requirements, it is a good chance to have some discussions before actually removing deprecated 2.0 APIs.
@xuzhenbao Please have a look at the RSA part.
I understand. My proposal is to reintroduce the framework v2 headers install and RSA conan create test in PR. |
It's a good idea to temporarily reintroduce framework v2 headers. Now that 2.4.0 is available, I am working on introducing it into my day job projects. |
# Conflicts: # CHANGES.md
This reverts commit 4050a03.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Given that the removal of the deprecated headers and therefore the refactor RSA will be done later, I will merge this PR. |
This PR removes the installation of the deprecated headers (those without the
celix_
prefix) from theutils
andframework
libraries.This is a task in #509.
Additionally, the PR removes the installation and usage of the v2 headers for the
shell_api
,log_service_api
, andpubsub_spi
libraries.As a consequence, the
shell_bonjour
andpsa_udp_mc
bundles, which relied respectively on the v2shell_api
and v2 pubsub serializer api and both hasn't been maintained, are also removed.Lastly, the remote service admin bundles/libraries have been using the
service_reference
andhashmap
in their API/SPI. As a result, they are not currently usable downstream. Addressing this requires a significant effort; thus, for this PR, I've disabled the Conan test package test for RSA. This will be addressed in a future PR.