URL to the Kafka brokers must be configured with the brokers option after upgrade to Quarkus 2.1.0.Final #2939
Comments
|
Adding |
|
The workaround suggested above no longer seems to work with quarkus 2.8.0 and camel 3.16.0 When using the suggested new line in The following error was received: Similar errors for variations of the property: Property: Property: |
|
A new workaround was identified here: apache/camel-quarkus-examples#86 |
|
The bug on dev mode/ test mode is outdated. |
|
@zbendhiba I think it has to add this option, please check #3742 (comment) |
|
I'm 1000% sure on dev mode it works without any workaround. As I use it all the time on my demos. I guess the problem here gets from using Kafka dev services in the tests, and I'm not sure if this is a Quarkus feature, maybe just a mistake of mine. Let me check |
|
@zhfeng what's happening here is that the test profile doesn't have the same behaviour as dev mode. And you are tricking it but letting it fallback to prod. When the tests run, we aren't in the dev mode. So how does it get the kafka brokers. I don't thing it's a big bug. It's a nice to have but not something urgent. The solution here is as simple as adding a TestResource class to handle the kafka instance |
|
@zbendhiba it's only needed when running the IT tests in native mode. In test or dev mode, we add a RunTimeConfigurationDefaultBuildItem in KafkaProcessor but it does not work in native mode. I raise a PR which introduces a BuildItem in DevKafkaService to add additional config but it did not be accepted by Quarkus team. So we still need to add |
|
But for this issue I think it could be closed since it has been resolved in test or dev mode. |
|
@zhfeng Yeah, thanks for explanation. and for pointing out to the interesting discussion around your PR BTW, I'm planning on deleting this example, as it doesn't bring anything new compared to what we have already in our many kafka integration tests |
|
yeah, please leave some notes in the document about running the IT test in the native mode with |
|
Let me take a deeper look into this. We may be able to work some magic to get this working for the native use case with |
|
Hmm, nice catch! @jamesnetherton How do you get it? :) |
It's amazing what you discover when debugging your way through the Quarkus test framework code 😉 |
|
@jamesnetherton any update? |
I can't make it work with |
|
I found a way with Not sure if the Kafka extension is the best place for such code - WDYT? Maybe the better long term solution would be to have a dedicated If we think this solution is too heavyweight, then we could just document the workarounds. |
|
Thanks @jamesnetherton and it looks good to me. It definetly need |
|
@jamesnetherton nice idea, but I would prefer to open an issue describing the idea about why having a camel-quarkus-test dependency, share the link and gather feedbacks for it. Before deciding whether we have enough value to go to this road |
|
@zbendhiba The value add of having a dedicated test dependency is already mostly agreed upon. See #3511 & #3847. |
Happens in the Kafka example after the upgrade to Quarkus 2.1.0.Final
Probably related to d6a9091
The text was updated successfully, but these errors were encountered: