Upgrade to Camel Quarkus 2.3.0, make the examples runnable against alternative BOMs #55
Conversation
* example(jdbc-datastore): #3056 Adding new simple example * Removing JPA and fixing docs * Adding a new group for jdbc-datasource * Adding missing license header * Updating docs * Re-introducing quarkus-health microprofile * Fix README numbering and remove dangling files Co-authored-by: James Netherton <[email protected]>
ppalaga
force-pushed
the
211005-alt-boms
branch
2 times, most recently
from
59287d8 to
8e83d94
Compare
| as long as you play with the example code in dev mode (a.k.a. `mvn quarkus:dev` - read more [here](https://quarkus.io/guides/getting-started#development-mode)) | ||
| or as long as you only run the supplied tests (`mvn test`). | ||
| In those situations, Quarkus tooling starts a Redpanda image for you via [Quarkus Dev Services](https://quarkus.io/guides/kafka-dev-services) | ||
| and it also configures the application so that you do not need touch anything in `application.properties`. | ||
|
|
There was a problem hiding this comment.
I reworded this a little bit. @jamesnetherton or @aldettinger could you please review, whether it makes sense?
| @@ -23,8 +23,7 @@ timer.period = 10000 | |||
| timer.delay = 10000 | |||
|
|
|||
| # Kafka instance without Authentication | |||
| # Passing ${kafka.bootstrap.servers} is a workaround for https://github.com/apache/camel-quarkus/issues/2939 | |||
| camel.component.kafka.brokers=${brokers:${kafka.bootstrap.servers}} | |||
| #camel.component.kafka.brokers=${brokers} | |||
There was a problem hiding this comment.
apache/camel-quarkus#2939 not being an issue anymore, I hope commenting the line back and removing ${kafka.bootstrap.servers} makes up a valid suggestion for end users?
There was a problem hiding this comment.
I think it's safe. It's how the previous impl was configured.
|
Hm... the Kafka example fails in native mode. Isn't the dev service magic supposed to work there as well, @jamesnetherton ? |
Yes, it should. Maybe restore the workaround for now and I can investigate further since I'm working in that area at the moment anyway. |
|
ppalaga
force-pushed
the
211005-alt-boms
branch
from
8e83d94 to
843a2d5
Compare
Fix apache/camel-quarkus#3152