chore(trait): revert default health enabled #5516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codegen to be regenerated after this is fixed: #5497 (comment) |
We must identify if a rolled out Pod after an upgrade is turning ready as expected. If not we have a possible breaking compatibility change
It turned out to be a breaking compatibility change as the switch would require a forcefully rebuild that is not done automatically by the operator during upgrade procedures.
squakez
force-pushed
the
chore/revert_health_enabled
branch
from
19c5747 to
958b041
Compare
|
Flaky test reported: #5521 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR partially reverts the work done in #5096. While working on the upgrade I realized we must strengthen the test and make sure that any automatic Pod rollout, after the operator upgrade, must finish successfully. This lead to the verification that the health trait set by default in the aforementioned PR does introduce a breaking compatibility change, as it requires a rebuild of the application due to the need to get the Camel health dependencies. This would have turn all Integrations in an unready status as soon we have moved to upcoming release version.
Release Note