(#5489) Groovy > Yaml

[tdiesler]

There will be so many changes ... so perhaps we do this incrementally

[squakez]

LGTM. However we must not add any file example here directly. For those we have the https://github.com/apache/camel-k-examples/tree/main/generic-examples

All along the documentation we just need to replace the snippets with the yaml DSL, that should be enough. And yes, feel free to open separate PR and do it iteratively if you prefer.

[tdiesler]

Do you know what this is ...
https://github.com/apache/camel-k/tree/main/docs/modules/ROOT/examples/js

$ git grep ck.js                                    
docs/antora.yml:    requires: "'util=camel-website-util,ck=xref:js/ck.js'"

[squakez]

Do you know what this is ... https://github.com/apache/camel-k/tree/main/docs/modules/ROOT/examples/js

$ git grep ck.js                                    
docs/antora.yml:    requires: "'util=camel-website-util,ck=xref:js/ck.js'"

No, unfortunately not. We have some configuration magic that I am not familiar with. Mind that certain configuration are required by the main Camel project which is in charge to include the subproject (hence, Camel K among others) bits.

[squakez]

I'd leave the timer:tick instead. Any newcomer may confuse the name of the component with the DSL.

[squakez]

Some minor changes, the rest is good, thanks!

[github-actions]

⚠️ Unit test coverage report - coverage decreased from 38.2% to 38.1% (-0.1%)

[tdiesler]

All docs should be done - ready to merge

[oscerd]

If we merge, let's run the ci-build for website here: https://ci-builds.apache.org/job/Camel/job/Camel.website/job/main/

in case something is broken we need to fix it soon or revert.

[tdiesler]

$ ./docs/local-build.sh quick
[15:31:01.130] INFO (@djencks/antora-timer): stage playbookBuilt took 0.167s
[15:31:01.132] INFO (@djencks/antora-timer): Extensions after stage playbookBuilt took 0.002s
[15:31:01.135] INFO (@djencks/antora-timer): stage beforeProcess took 0.003s
[15:31:01.136] INFO (@djencks/antora-timer): Extensions after stage beforeProcess took 0.001s
[15:31:01.229] INFO (@djencks/antora-timer): stage uiLoaded took 0.093s
[15:31:01.229] INFO (@djencks/antora-timer): Extensions after stage uiLoaded took 0s
[15:31:01.258] INFO (@djencks/antora-timer): stage contentAggregated took 0.029s
[15:31:01.259] INFO (@djencks/antora-timer): Extensions after stage contentAggregated took 0.001s
[15:31:01.262] INFO (@djencks/antora-timer): stage contentClassified took 0.003s
[15:31:01.289] INFO (@djencks/antora-timer): Extensions after stage contentClassified took 0.027s
[15:31:02.842] INFO (@djencks/antora-timer): stage documentsConverted took 1.553s
[15:31:02.842] INFO (@djencks/antora-timer): Extensions after stage documentsConverted took 0s
[15:31:02.849] INFO (@djencks/antora-timer): stage navigationBuilt took 0.007s
[15:31:02.849] INFO (@djencks/antora-timer): Extensions after stage navigationBuilt took 0s
[15:31:03.049] INFO (@djencks/antora-timer): stage pagesComposed took 0.2s
[15:31:03.049] INFO (@djencks/antora-timer): Extensions after stage pagesComposed took 0s
[15:31:03.050] INFO (@djencks/antora-timer): stage redirectsProduced took 0.001s
[15:31:03.050] INFO (@djencks/antora-timer): Extensions after stage redirectsProduced took 0s
[15:31:03.052] INFO (@djencks/antora-timer): stage siteMapped took 0.002s
[15:31:03.052] INFO (@djencks/antora-timer): Extensions after stage siteMapped took 0s
[15:31:03.052] INFO (@djencks/antora-timer): stage beforePublish took 0s
[15:31:03.052] INFO (@djencks/antora-timer): Extensions after stage beforePublish took 0s
Site generation complete!
Open file:///Users/tdiesler/git/camel-website/documentation in a browser to view your site.
[15:31:03.133] INFO (@djencks/antora-timer): stage sitePublished took 0.081s
[15:31:03.133] INFO (@djencks/antora-timer): stage sitePublished took 0s
[15:31:03.133] INFO (@djencks/antora-timer): total build time 2.17s

[oscerd]

$ ./docs/local-build.sh quick
[15:31:01.130] INFO (@djencks/antora-timer): stage playbookBuilt took 0.167s
[15:31:01.132] INFO (@djencks/antora-timer): Extensions after stage playbookBuilt took 0.002s
[15:31:01.135] INFO (@djencks/antora-timer): stage beforeProcess took 0.003s
[15:31:01.136] INFO (@djencks/antora-timer): Extensions after stage beforeProcess took 0.001s
[15:31:01.229] INFO (@djencks/antora-timer): stage uiLoaded took 0.093s
[15:31:01.229] INFO (@djencks/antora-timer): Extensions after stage uiLoaded took 0s
[15:31:01.258] INFO (@djencks/antora-timer): stage contentAggregated took 0.029s
[15:31:01.259] INFO (@djencks/antora-timer): Extensions after stage contentAggregated took 0.001s
[15:31:01.262] INFO (@djencks/antora-timer): stage contentClassified took 0.003s
[15:31:01.289] INFO (@djencks/antora-timer): Extensions after stage contentClassified took 0.027s
[15:31:02.842] INFO (@djencks/antora-timer): stage documentsConverted took 1.553s
[15:31:02.842] INFO (@djencks/antora-timer): Extensions after stage documentsConverted took 0s
[15:31:02.849] INFO (@djencks/antora-timer): stage navigationBuilt took 0.007s
[15:31:02.849] INFO (@djencks/antora-timer): Extensions after stage navigationBuilt took 0s
[15:31:03.049] INFO (@djencks/antora-timer): stage pagesComposed took 0.2s
[15:31:03.049] INFO (@djencks/antora-timer): Extensions after stage pagesComposed took 0s
[15:31:03.050] INFO (@djencks/antora-timer): stage redirectsProduced took 0.001s
[15:31:03.050] INFO (@djencks/antora-timer): Extensions after stage redirectsProduced took 0s
[15:31:03.052] INFO (@djencks/antora-timer): stage siteMapped took 0.002s
[15:31:03.052] INFO (@djencks/antora-timer): Extensions after stage siteMapped took 0s
[15:31:03.052] INFO (@djencks/antora-timer): stage beforePublish took 0s
[15:31:03.052] INFO (@djencks/antora-timer): Extensions after stage beforePublish took 0s
Site generation complete!
Open file:///Users/tdiesler/git/camel-website/documentation in a browser to view your site.
[15:31:03.133] INFO (@djencks/antora-timer): stage sitePublished took 0.081s
[15:31:03.133] INFO (@djencks/antora-timer): stage sitePublished took 0s
[15:31:03.133] INFO (@djencks/antora-timer): total build time 2.17s

This is good, but the full build from the website on the CI might fail anyway. It happened before. But this is great! Thanks @tdiesler

[tdiesler]

Could we run this again pls?

[tdiesler]

Ready to merge

[oscerd]

https://ci-builds.apache.org/job/Camel/job/Camel.website/job/main/1612/

[tdiesler]

Thanks @oscerd - the msg for the squashed commit is a little awkward
As you might recall, I squash stuff already before I do a PR

[oscerd]

Sorry for that.

[oscerd]

The build seems to be fine. The website should be online in a few minutes

[squakez]

@tdiesler we did changes in autogenerated code in traits. It is likely that tonight it will be reverted back by auto updates. You need to change the content of the trait golang files and later make generate to refresh the autogen content.

[tdiesler]

I rebased those changes on main and see no differences. I believe I already changed stuff at the source i.e. the trait Go files. Also, I'm having trouble running make generate for some unknown reason - it works for @christophd who is also on MacOS when we last talked

[squakez]

See:

camel-k/docs/modules/traits/pages/3scale.adoc

Line 21 in 4317da8

$ kamel run --trait 3scale.[key]=[value] --trait 3scale.[key2]=[value2] integration.groovy

We need to make the change on the go file and then, make generate.

[tdiesler]

Like so ...
787a1d6