-
Notifications
You must be signed in to change notification settings - Fork 350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: remove the need for a storage #4483
Conversation
@gansheer I had to temporary use root in this PR to be able to build. I'm testing with the |
67c853b
to
275f35e
Compare
The fix addressing the concerns in previous comment should be available in container-tools/spectrum#37. Once that got merged and we bump the spectrum dependency we should be able to move back the execution of builder pod with non-root privileges. |
157af02
to
e1102e0
Compare
cb1dc29
to
fc834ce
Compare
43b0bfb
to
4b44802
Compare
Failures are likely due to #4511 |
1947f91
to
50caa5a
Compare
6243cd4
to
3d6526b
Compare
This is the one used in the builder image
3d6526b
to
4a8072d
Compare
e790715
to
728f1da
Compare
The failing check did not fail on previous attempt, merging. |
@gansheer FYI, this is merged |
🥳 |
While working on #4025 we have introduced the requirement of a storage as a
PersistentVolumeClaim
. However, I've realized this is actually nothing else than a Maven Proxy [1]. The presence of a storage add some complexity to the management of the operator. We also expect that any enterprise should already have a Maven Proxy, so, it makes sense to use it as a Maven best practice.We are still able to use a PVC if the user wants to have this further optimization, and I'm adding some documentation to explain how to do that.
[1] https://camel.apache.org/blog/2023/06/camel-k-maven-proxy/
Release Note