fix(core): Permissions on operator and builder pods (S2I compatibility) #4487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oscerd
approved these changes
Jun 14, 2023
squakez
approved these changes
Jun 14, 2023
* Change default Dockerfile user from 1001 to 1001:0 * Add builder pod security context compatible with OCP SecurityContextConstraint restricted-v2 (https://docs.openshift.com/container-platform/4.12/authentication/managing-security-context-constraints.html) * Change Dockerfile S2I to user compatible with SecurityContextConstraint * Add permission to get a namespace to operator to ensure SecurityContextConstraint labels in namespace are accessible * Remove root FsGroup on operator as it is no longer needed
gansheer
force-pushed
the
fix/4476_permissions_errors
branch
from
173a2eb to
02bfee4
Compare
|
@oscerd @christophd @claudio4j could on of you please launch the tests ? |
squakez
approved these changes
Jul 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #4476
For compatibility with S2I publish strategy:
This has been tested on:
Note: there is a different user on builder pod dockerfile (
--chown) because the BuildConfig binary strategy replaces 775 permissions with 755, so we need to fall back to owner user.Release Note