[Backport 1.12.x] fix: Limit parallel builds on operator #4284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oscerd
approved these changes
Apr 26, 2023
oscerd
approved these changes
Apr 26, 2023
squakez
approved these changes
Apr 26, 2023
|
Please, rebase as we solved the github actions issue. |
christophd
force-pushed
the
backport-1.12.x/limit-parallel-builds
branch
2 times, most recently
from
92bb004 to
1dabe5d
Compare
|
@squakez rebase done, could you please trigger the workflow once again 🙏 |
- Avoid many parallel integration builds - Monitor all builds started by the operator instance and limit max number of running builds according to given setting - By default use max running builds limit = 3 for build strategy routine - By default use max running builds limit = 10 for build strategy pod - Add max running builds setting to IntegrationPlatform - Add some documentation on build strategy and build queues
- Add option to CLI install command to set max running builds setting
christophd
force-pushed
the
backport-1.12.x/limit-parallel-builds
branch
from
1dabe5d to
70869cc
Compare
- Wait for IntegrationPlatforms in user namespaces to become ready before starting new builds - Avoids racing conditions on build and integration platform reconciliation loops - Avoids 1st build to succeed before 3rd build has been scheduled (skips the max build limit)
- Wait for IntegrationPlatform to become ready after operator installation - Avoids resources to get stuck in waiting for integration platform state
- Improve assertions on max parallel running builds - Make sure to properly dump test namespaces on failure
christophd
force-pushed
the
backport-1.12.x/limit-parallel-builds
branch
from
1acb75b to
ef0e40f
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manual backport of #4233