-
Notifications
You must be signed in to change notification settings - Fork 350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Limit parallel builds on operator #4233
fix: Limit parallel builds on operator #4233
Conversation
52467de
to
077be4d
Compare
077be4d
to
5e66e20
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general I think it's a good feature to have. I just am not sure to understand why the controller variable slips into the Build resource. Also, I think this requires an e2e in order to validate such feature, ie, a build really queues up when the max limit is reached.
5e66e20
to
098577e
Compare
@claudio4j @squakez could you please rerun the failed workflows? I assume that the errors are flaky tests and are not related to the changes made in this PR |
@squakez YAY, checks are green. I will rebase and resolve the conflicts |
Please, mind my previous comments as well:
Thanks. |
- Avoid many parallel integration builds - Monitor all builds started by the operator instance and limit max number of running builds according to given setting - By default use max running builds limit = 3 for build strategy routine - By default use max running builds limit = 10 for build strategy pod - Add max running builds setting to IntegrationPlatform - Add some documentation on build strategy and build queues
098577e
to
21c2528
Compare
a6338b2
to
7d119b5
Compare
7d119b5
to
96d28c4
Compare
@squakez I finally managed to add an E2E test, could you please trigger the workflow once more? thx |
@squakez no idea what is happening with the jobs here. |
let's give another spin |
Usually the builds get strictly queued because of potential image layering in terms of reusing the integration kits. There are situations though where parallel builds on the operator are possible.
Release Note