Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: won't panic on error handler validation failure #4247

Merged
merged 1 commit into from
Apr 13, 2023

Conversation

squakez
Copy link
Contributor

@squakez squakez commented Apr 12, 2023

Introduced a validation for each kind of error handler.

With this PR we make sure that every error handler type is validated against the expected configuration. Validate() func need to be configured for each type according the logic required for it (in this case it seems only the sink requires some validation).

Closes #3586

Release Note

fix: won't panic on error handler validation failure

Introduced a validation for each kind of error handler.

Closes apache#3586
@squakez squakez added the kind/bug Something isn't working label Apr 12, 2023
@squakez
Copy link
Contributor Author

squakez commented Apr 12, 2023

@essobedo with this one we should take care of providing the expected validation logic for each error handler type and fail during parse. It's a bit different on the first work you did on #3595, if you want to give a look.

Copy link
Contributor

@essobedo essobedo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice 👍

@squakez squakez merged commit cc8d518 into apache:main Apr 13, 2023
@squakez squakez deleted the fix/3586 branch April 13, 2023 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong KameletBinding definition leads to operator panic
2 participants