fix: Prevent operator panic on wrong Kamelet binding #3595
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
essobedo
force-pushed
the
3586/avoid-panic-on-wrong-kamelet-binding
branch
from
1279535 to
87e1f90
Compare
essobedo
changed the title
essobedo
force-pushed
the
3586/avoid-panic-on-wrong-kamelet-binding
branch
from
87e1f90 to
cd1b08d
Compare
oscerd
approved these changes
Aug 31, 2022
|
The builds are failing due to:
Both are not related to these changes |
tadayosi
reviewed
Sep 2, 2022
essobedo
force-pushed
the
3586/avoid-panic-on-wrong-kamelet-binding
branch
from
cd1b08d to
dbed12a
Compare
squakez
reviewed
Sep 2, 2022
There was a problem hiding this comment.
Thanks for the work. This PR solves certain specific cases (ie, a sink with a not nil endpoint), but still fails in case of a valid yaml specification that does not fit the expected ErrorHandler specification. A definitive fix should be done in the parseErrorHandler func, when we unmarshal the configuration. Not sure if there is an easy and elegant way to validate against the expected schema. In any case, I'd keep this work on hold, as we may need to apply some refactoring due to apache/camel-k-runtime#868
tadayosi
reviewed
Sep 7, 2022
|
Ok no problem once apache/camel-k-runtime#868 will be fixed, I will try to find a more elegant approach |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #3586
Motivation
A Kamelet binding in the wrong format can lead to operator panic which needs to be avoided.
Modifications:
Release Note