Native binding 1.10 #3718
Merged
Native binding 1.10 #3718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oscerd
approved these changes
Oct 5, 2022
squakez
approved these changes
Oct 5, 2022
tadayosi
approved these changes
Oct 6, 2022
|
We need to rebase this one as #3692 is merged now. |
Closed
bouskaJ
force-pushed
the
native_binding_1.10
branch
from
5d0f551 to
12485d9
Compare
|
It looks like the tests are failing. I've restarted to see if it was a transient failure though. |
|
I think the failures are related to the timeouts (probably given by lack of resource for Native builds). I'm merging it to unlock the release and have a look at the stability of those tests afterward. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport of #3670